Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include of non-modular header inside framework module 'firebase_messaging.FLTFirebaseMessagingPlugin' #12962

Closed
1 task done
Wahidsmn opened this issue Jun 16, 2024 · 8 comments
Labels
Needs Attention This issue needs maintainer attention. resolution: invalid This doesn't seem right and might not belong here. resolution: wontfix This will not be worked on type: bug Something isn't working

Comments

@Wahidsmn
Copy link

Is there an existing issue for this?

  • I have searched the existing issues.

Which plugins are affected?

Messaging

Which platforms are affected?

iOS

Description

After upgrading to Mac OS 15 and downloading xcode 16, i am getting the following error when trying to build the app in XCODE.

/Users/--/.pub-cache/hosted/pub.dev/firebase_messaging-15.0.1/ios/Classes/FLTFirebaseMessagingPlugin.h:12:9 Include of non-modular header inside framework module 'firebase_messaging.FLTFirebaseMessagingPlugin': '/Users/--/Documents/projects/flutter_app/ios/Pods/Headers/Public/Firebase/Firebase.h'

Reproducing the issue

upgrade mac os to 15 beta
download xcode 16 beta
try to build the app in xcode.

Firebase Core version

3.1.0

Flutter Version

3.22.2

Relevant Log Output

No response

Flutter dependencies

Expand Flutter dependencies snippet
Replace this line with the contents of your `flutter pub deps -- --style=compact`.

Additional context and comments

No response

@Wahidsmn Wahidsmn added Needs Attention This issue needs maintainer attention. type: bug Something isn't working labels Jun 16, 2024
@whes1015
Copy link

i have the same error

@Lyokone
Copy link
Contributor

Lyokone commented Jun 17, 2024

Hello. The underlying SDK does not officially supports beta version currently. It will be solve before release.

@Lyokone Lyokone closed this as completed Jun 17, 2024
@Lyokone Lyokone added resolution: invalid This doesn't seem right and might not belong here. resolution: wontfix This will not be worked on labels Jun 17, 2024
@AlexStrNik
Copy link

@Lyokone cmon, it's one line fix. Just change ios/Classes/FLTFirebaseMessagingPlugin.h:12:9 to @import FirebaseMessaging;

@RafaelZasas
Copy link

Hello. The underlying SDK does not officially supports beta version currently. It will be solve before release.

Does this mean it is impossible to run any apple betas while developing apps with flutter and firebase?

@AlexStrNik
Copy link

Hello. The underlying SDK does not officially supports beta version currently. It will be solve before release.

Does this mean it is impossible to run any apple betas while developing apps with flutter and firebase?

Actually i discovered no issues with firebase itself, the only problem is something changed in Xcode 16, perhaps "Allow Non-modular Includes in Framework Modules" setting doesn't work anymore. So it should be fixed in this library not in underlying library nor somewhere else

@Wahidsmn
Copy link
Author

Wahidsmn commented Jun 22, 2024

I found a solution until this is fixed. hopefully this helps someone. @AlexStrNik is right, xcode setting changed in the latest beta version of xcode, maybe apple is moving away from supporting the include of non-modular header inside framework modules.

steps to solve

  1. select the runner
  2. go to build settings
  3. scroll down to Apple Clang - Language - Modules
  4. change the Allow Non-modular includes in Framework Modules to "Yes" (by default this is set to "No" now)

Image 2024-06-22 at 3 15 AM

@ZahraVe
Copy link

ZahraVe commented Jul 17, 2024

I'm facing the same issue and also can't locate the 'Allow Non-modular Includes in Framework Modules' in Xcode 16 beta 3. This option is available in Xcode 15, set to 'No', and the project runs without issues there. I'm currently using Flutter (Channel stable, 3.22.2).

Any suggestion?

@heavenstay
Copy link

I'm facing the same issue and also can't locate the 'Allow Non-modular Includes in Framework Modules' in Xcode 16 beta 3. This option is available in Xcode 15, set to 'No', and the project runs without issues there. I'm currently using Flutter (Channel stable, 3.22.2).

Any suggestion?

Same for me. On Xcode 16 beta 3, I can't find the 'Allow Non-modular Includes in Framework Modules' option. I recently sent a message to Xcode assistance, so I might have a solution from Apple soon. I will let you know as soon as I have any updates.

@firebase firebase locked and limited conversation to collaborators Jul 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Needs Attention This issue needs maintainer attention. resolution: invalid This doesn't seem right and might not belong here. resolution: wontfix This will not be worked on type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

7 participants