Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI errors out when project name is less than 5 chars #2514

Closed
plug-n-play opened this issue Aug 2, 2020 · 4 comments · Fixed by #8057
Closed

CLI errors out when project name is less than 5 chars #2514

plug-n-play opened this issue Aug 2, 2020 · 4 comments · Fixed by #8057

Comments

@plug-n-play
Copy link

plug-n-play commented Aug 2, 2020

[REQUIRED] Environment info

Firebase version 8.6.0

firebase-tools:

Platform:
macOS 10.14.6

[REQUIRED] Test case

Firebase CLI Issue

[REQUIRED] Steps to reproduce

  1. Open Terminal
  2. Type firebase init
  3. Enter project name as less than 6 characters

[REQUIRED] Expected behavior

The terminal should display validation error and re-prompt to enter valid name greater than 6 or more characters.

[REQUIRED] Actual behavior

firebase init errors out
Please see attached debug logs

firebase-debug.log

@google-oss-bot
Copy link
Contributor

This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

@aditmodhvadia
Copy link

@plug-n-play Seems like a feature request and not a bug in my opinion. Is it causing any other problems for you?

@plug-n-play
Copy link
Author

@aditmodhvadia - IMHO, this is an existing feature which is not working as expected in the given use case. There is no description of what went wrong when the request to execute the existing feature fails and relies on user to open the created debug file where error description is found in the logs. Atleast the error description should be displayed in the terminal not everyone tends to open the debug file.

@aditmodhvadia
Copy link

aditmodhvadia commented Aug 4, 2020

I get your point @plug-n-play . Then the bug over here is to show what went wrong in the terminal and, the feature request can be to re-prompt the user to enter the name of the project again. Just sharing my thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants