Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex GA] Regenerate docs after Vertex GA changes #8505

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Sep 17, 2024

Regenerated docs based on all code changes for Vertex GA so far.

Changes are:

  • added Schema classes
  • remove "unspecified" enum values
  • change optionality on some properties

@hsubox76 hsubox76 marked this pull request as ready for review September 17, 2024 18:24
@hsubox76 hsubox76 requested a review from a team as a code owner September 17, 2024 18:24
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 17, 2024

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Sep 17, 2024

docs-devsite/vertexai-preview.generationconfig.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.generationconfig.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.schema.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.schema.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.schemaparams.md Outdated Show resolved Hide resolved
@hsubox76 hsubox76 requested a review from a team as a code owner September 19, 2024 16:56
Copy link

changeset-bot bot commented Sep 19, 2024

⚠️ No Changeset found

Latest commit: 832dd3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments. Some of the changes have added some source files to this PR, that are the source of the changes. You don't have to review them, you can just look at the markdown files.

Copy link
Contributor

@DellaBitta DellaBitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a problem that docs-devsite/_toc.yaml was removed?

@hsubox76 hsubox76 force-pushed the ch-schema-docs branch 2 times, most recently from e6195cd to 145e5d8 Compare September 23, 2024 17:30
@hsubox76 hsubox76 changed the title Generate Schema docs [Vertex GA] Generate Schema docs Sep 23, 2024
@hsubox76 hsubox76 added this to the Vertex GA milestone Sep 23, 2024
@hsubox76 hsubox76 changed the base branch from ch-schema to v11 September 24, 2024 17:25
@hsubox76 hsubox76 changed the base branch from v11 to ch-docs-rename-base September 25, 2024 16:17
@hsubox76 hsubox76 changed the title [Vertex GA] Generate Schema docs [Vertex GA] Regenerate docs after Vertex GA changes Sep 25, 2024
docs-devsite/vertexai.generationconfig.md Outdated Show resolved Hide resolved
docs-devsite/vertexai.generationconfig.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai.schemashared.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.md Outdated Show resolved Hide resolved
docs-devsite/vertexai-preview.schema.md Outdated Show resolved Hide resolved
@hsubox76 hsubox76 force-pushed the ch-schema-docs branch 2 times, most recently from ff3aaf6 to 9af2001 Compare September 30, 2024 20:26
docs-devsite/vertexai.generationconfig.md Outdated Show resolved Hide resolved
docs-devsite/vertexai.schemashared.md Outdated Show resolved Hide resolved
docs-devsite/vertexai.generationconfig.md Outdated Show resolved Hide resolved
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v5.0

@hsubox76 hsubox76 changed the base branch from ch-docs-rename-base to v11 October 15, 2024 20:08
@hsubox76 hsubox76 changed the base branch from v11 to ch-docs-rename-base October 15, 2024 20:09
@hsubox76 hsubox76 requested a review from a team as a code owner October 15, 2024 20:14
@hsubox76 hsubox76 changed the base branch from ch-docs-rename-base to v11 October 15, 2024 20:15
@hsubox76 hsubox76 changed the base branch from v11 to ch-docs-rename-base October 15, 2024 20:24
fill out Schema builder

refine design

Update doc comments

More fixes to doc comments

Fixes based on testing

fix error class

Allow raw json in responseSchema

set SchemaShared to public

fix docs

revert docs

remove other added docs

restore toc

rerun docgen

redo docs

rename to vertexai

remove old api preview

fix some merge issues

Update API reports

Address some PR comments

Address comments
@hsubox76 hsubox76 changed the base branch from ch-docs-rename-base to v11 October 15, 2024 20:30
@hsubox76 hsubox76 merged commit ec0a670 into v11 Oct 15, 2024
2 of 3 checks passed
@hsubox76 hsubox76 deleted the ch-schema-docs branch October 15, 2024 20:31
hsubox76 added a commit that referenced this pull request Oct 17, 2024
* Add node engines fields specifying a minimum of 18 (#8457)

* Make memory lru gc the default (#8110)

* Make memory lru gc the default

* undo yarn.lock

* Make memory lru gc the default

* Fix tests

* V11 release removal of node-fetch and undici dependencies (#8492)

Our v11 release will require node 18+. Since fetch has been introduced in these node versions, we can remove our dependency on third party fetch implementations.

This change removes our usage of fetch variants undici and node-fetch for our node target builds and our CI tools.

* V11 - Remove functions node bundle (#8507)

With the removal of fetch we no long need to create a node bundle for functions. Instead the sourcebase may become isomorphic, so long as we remove the older node sources. And that's what the PR does!

* Initial changes for Vertex GA packaging (#8498)

* [Vertex GA] Rewrite Schema (#8479)

* [Vertex GA] Add new endpoint and error message. (#8497)

* [Vertex GA] Miscellaneous breaking changes for Vertex GA (#8514)

* Remove ES5 Support (#8509)

* Emit a module package file for functions ESM builds (#8517)

* Update API_NOT_ENABLED error for Vertex (#8549)

* Upgrade cjs bundles for storage and performance (#8557)

These should have been part of the bigger PR, but I missed these.

* Rollup JS files with rollup-typescript-plugin (#8503)

The rollup-typescript-plugin does not transpile JS files using the TS
compiler by default. This means that external dependencies that provide
JS bundles will not be transpiled to the target ES version specified in
the TypeScript config used by the plugin.

This resulted in one of our dependencies (https://github.com/jakearchibald/idb)
being included in the CDN bundles without being transpiled to
ES5 (the target ES version). Since this dependencies bundle uses
ES2018 syntax (object spread operator `{ ...x }`), this upgraded our CDN
bundles' minimum ES version requirement to ES2018 which isn't compatible with older browser versions.
To see the ES2018 syntax in one of the CDN bundles, see
https://www.gstatic.com/firebasejs/10.13.1/firebase-app.js and search for `...oldTraps`.

* Fix tsc errors in vertex tests (#8562)

* Make SafetySettings.method optional (#8567)

* Make SafetySettings.method optional

* Update API reports

---------

Co-authored-by: hsubox76 <[email protected]>

* [Vertex GA] Regenerate docs after Vertex GA changes (#8505)

* Close emulator file after download is complete (#8572)

* close file

* Add test:ci to end of test command in CI

* revert workflow file changes

* format

* rename vertexai package reference in a changeset (#8573)

* Missed one doc change from a PR (#8575)

* Overwrite undefined candidate index (#8577)

* Overwrite undefined candidate index

* Fix index overwrite condition to only be true when index is not a property

* Upgrade Vertex Mock Responses to V5 (#8579)

* Upgrade to mock responses v4

* Upgrade from v4 to v5 mock responses

---------

Co-authored-by: wu-hui <[email protected]>
Co-authored-by: DellaBitta <[email protected]>
Co-authored-by: Daniel La Rocque <[email protected]>
Co-authored-by: hsubox76 <[email protected]>
@firebase firebase locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants