FirebaseServerAppImpl: guard use of FinalizationRegistry based on its availability. #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 17bff19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Do we want to throw if releaseOnDeref is used an finalization registery is not available? |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
We already do in initializeServerApp. |
jamesdaniels
approved these changes
Jun 25, 2024
dlarocque
approved these changes
Jun 28, 2024
This was referenced Jun 28, 2024
Merged
tom-andersen
pushed a commit
that referenced
this pull request
Jul 24, 2024
… availability. (#8335) There was code that would errantly attempt to allocate a FinalizationRegstiry in FirebaseServerAppImpl regardless of the existence of releaseOnDeref field, and this caused issues in some edge environments. This change fixes that issue.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
The code had already guarded use of the
FinalizationRegstiryduring the initialization ofFirebaseServerAppininitializeServerAppif thereleaseOnDerefconfiguration parameter was defined. This gating was to provide functionality in older node versions. However, there was other code that would errantly attempt to allocate aFinalizationRegstiryinFirebaseServerAppImplregardless of the existence ofreleaseOnDereffield, and this caused issues in some edge environments.This change fixes that issue.
Testing
I had tested this previously using Node v14.14.0, which is the release version previous to the reported addition of the FinalizationRegistry, and our code had worked. However, it appears that 14.14.0 actually includes the FinalizationRegistry, so my tests completed successfully when they shouldn't have.
I was able to reproduce this problem in Node 14.0.0, and that's the version I used to test this fix.
API Changes
N/A.