Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grpc to 1.11.3 #785

Merged
merged 4 commits into from
May 11, 2018
Merged

Update grpc to 1.11.3 #785

merged 4 commits into from
May 11, 2018

Conversation

mmermerkaya
Copy link
Contributor

Fixes #780.

jshcrowthe
jshcrowthe reviewed May 11, 2018
View reviewed changes
Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all looks good to me, however I don't know if @mikelehen et. al. have had a chance to look at it. I'll defer to them.

@mikelehen
Copy link
Contributor

I think this is fine, but the branch is out-of-date with master and needs to be updated. Please update and then assign to me if you'd like a review.

cc/ @rsgowman since he was looking into #780.

@firebase firebase deleted a comment from googlebot May 11, 2018
@jshcrowthe jshcrowthe merged commit c150044 into master May 11, 2018
@jshcrowthe jshcrowthe deleted the mmermerkaya-update-grpc branch May 11, 2018 18:04
This was referenced May 15, 2018
Closed
Closed
@firebase firebase locked and limited conversation to collaborators Oct 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jshcrowthe jshcrowthe jshcrowthe approved these changes

@mikelehen mikelehen mikelehen approved these changes

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@wilhuff wilhuff Awaiting requested review from wilhuff

Assignees

@mikelehen mikelehen

Labels
api: core api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc causing npm install failure on Linux
4 participants
@mmermerkaya @mikelehen @jshcrowthe @google-oss-bot