Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override Database Version Reported by the SDK #314

Closed
hiranya911 opened this issue Nov 10, 2017 · 2 comments
Closed

Override Database Version Reported by the SDK #314

hiranya911 opened this issue Nov 10, 2017 · 2 comments
Labels
api: database

Comments

@hiranya911
Copy link
Contributor

@firebase/database reports the firebase.SDK_VERSION defined in @firebase/app as its version. This is not ideal in some 1p integrations like firebase-admin. In those cases we need the database client to report the version of the enclosing SDK. A possible solution could be altering the initStandalone() method to accept an optional version argument, and plumb that to the database client.
@google-oss-bot
Copy link
Contributor

Hey there! I couldn't figure out what this issue is about, so I've labeled it for a human to triage. Hang tight.

@google-oss-bot
Copy link
Contributor

Hmmm this issue does not seem to follow the issue template. Make sure you provide all the required information.

@hiranya911 hiranya911 mentioned this issue Nov 10, 2017
Closed
@firebase firebase locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api: database
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hiranya911 @jshcrowthe @google-oss-bot