Firebase Performance makes Ktor requests crash

[leinardi]

[REQUIRED] Step 1: Describe your environment

• Xcode version: Version 12.2 (12B45b)
• Firebase SDK version: 7.3.0 & 6.32.2
• Installation method: Zip file
• Firebase Component: Performance

[REQUIRED] Step 2: Describe the problem

Using Ktor together with Firebase Performance make the app crash with EXC_BAD_ACCESS.

The only workaround seems to remove Firebase Performance.

Steps to reproduce:

We are able to reproduce the issue using kotlin 1.4.21, ktor 1.5.0' and coroutines 1.4.1-native-mt.

Executing a Ktor request on a project where Firebase Performance is added and will crash the app as soon as the request starts.

The Ktor request can be as simple as this:

suspend fun ktorRequest(): String = httpClient.get<String>("https://en.wikipedia.org/wiki/Main_Page")

This is the stacktrace.txt

Relevant Code:

A sample KMM client crashing with Firebase Performance here (you might need to update the dependencies to the latest version): ktorio/ktor#1040

[maksymmalyhin]

Potentially related #6938.

[maksymmalyhin]

@leinardi Thank you for reporting the issue. Could you please attach the crash log to understand if it is the same issue as described at #6938.

[leinardi]

Hi @maksymmalyhin, thank you for the quick answer. What exactly do you mean by "crash log"? I already attached the stacktrace to the OP, isn't that the crash log?

[maksymmalyhin]

Ah, sorry, I missed the link.

As far as I understand, the file contains Kotlin stack trace for the crashed thread, is it correct? Would you be able to provide stack traces for other threads? Are native (iOS) thread stack traces also available?

[leinardi]

I have to check with my iOS colleague @kchromik on Monday (I am the KMM developer and he's doing the iOS integration).
We will report back on Monday, thanks for looking at the issue 👍

[kchromik]

The native stack trace doesn't differ from the one provided by @leinardi.

[maksymmalyhin]

@leinardi @kchromik We will try to reproduce the issue on our end to proceed with the investigation.

In the meanwhile you may try to disable Firebase Performance instrumentation by setting Performance .isInstrumentationEnabled property to false as a workaround. With isInstrumentationEnabled = false Performance SDK won't do any runtime modifications such ISA swizzling some objects to get network request stats, etc.

[kchromik]

Thanks @maksymmalyhin that fixed the issue.

[leinardi]

Thanks @maksymmalyhin that fixed the issue.

Let's say that worked around the issue 😅

A proper fix is still needed 😉 (please do not close this issue!)

[raymondlam]

An update, I was able to reproduce the crash using https://github.com/kotlin-hands-on/kmm-networking-and-data-storage as a sample app with the Firebase performance SDK and the current release for Kotlin.

I have confirmed that the crash is fixed once I switched the app to use the Kotlin EAP preview v1.4.30-RC which contains the fix in JetBrains/kotlin-native#4569!

I'll keep this issue open until the next release of Kotlin is publicly available.

[raymondlam]

Closing this as this has been fixed with Kotlin v1.4.30.
ktorio/ktor#1040 (comment)