Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to GMA 2024 major revision, Xcode 15, runners to macos-13 #1537

Merged
merged 65 commits into from
Mar 12, 2024
Merged

Update to GMA 2024 major revision, Xcode 15, runners to macos-13 #1537

merged 65 commits into from
Mar 12, 2024

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Feb 12, 2024 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Breaking changes in the GMA iOS SDK are listed here.

The changes needed in the C++ SDK are:

  • Update iOS deployment target to iOS 12. Normalize all of the iOS and tvOS deployment targets across the Podfiles and the Xcode projects.
  • Update Xcode version to 15.1. (This necessitates updating Mac runners from macos-12 to macos-13.)
  • Breaking changes in GADRequestConfiguration:
    • setSameAppKeyEnabled renamed to setPublisherFirstPartyIDEnabled
    • tagForUnderAgeofConsent changed from method to property
    • tagforChildDirectedTreatment changed from method to property
  • Breaking change in GADResponseInfo:
    • adNetworkClassName property replaced with loadedAdNetworkResponseInfo.adNetworkClassName
  • (For these breaking changes, the C++ SDK interface hasn't changed, just the underlying implementation.)

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Run integration tests in this PR, and packaging workflow.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Feb 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 12, 2024 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 9553745
Last updated: Tue Mar 12 17:00 PDT 2024
View integration test log & download artifacts

Failures Configs
gma [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseGmaTest.TestInterstitialAdLoad

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 13, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 13, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: failed This PR's integration tests failed. labels Feb 13, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 13, 2024
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Feb 14, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). tests: succeeded This PR's integration tests succeeded. labels Feb 14, 2024
@jonsimantov jonsimantov added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Feb 15, 2024
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Feb 15, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Feb 15, 2024
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Feb 15, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: failed This PR's integration tests failed. labels Mar 11, 2024
@github-actions github-actions bot added tests: failed This PR's integration tests failed. tests: succeeded This PR's integration tests succeeded. labels Mar 11, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 11, 2024
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 11, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. tests: succeeded This PR's integration tests succeeded. labels Mar 11, 2024
@jonsimantov jonsimantov changed the title Update to GMA 2024 major revision Update to GMA 2024 major revision, Xcode 15, runners to macos-13 Mar 11, 2024
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 12, 2024
@jonsimantov jonsimantov marked this pull request as ready for review March 12, 2024 01:50
@jonsimantov jonsimantov requested a review from a-maurice March 12, 2024 01:50
a-maurice
a-maurice approved these changes Mar 12, 2024
View reviewed changes
scripts/gha/integration_testing/xcodebuild.py Outdated Show resolved Hide resolved
@jonsimantov jonsimantov merged commit 9553745 into main Mar 12, 2024
30 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Mar 12, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 13, 2024
@firebase firebase locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-maurice a-maurice a-maurice approved these changes

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonsimantov @a-maurice