Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set tenantId back to null after setting it to something else #3398

Open
Rexios80 opened this issue Feb 3, 2022 · 11 comments
Open

Cannot set tenantId back to null after setting it to something else #3398

Rexios80 opened this issue Feb 3, 2022 · 11 comments
Labels

Comments

@Rexios80
Copy link

Rexios80 commented Feb 3, 2022

[REQUIRED] Step 2: Describe your environment

  • Android Studio version: VSCode (Flutter development)
  • Firebase Component: Auth
  • Component version: Whatever flutterfire is using

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

Set tenantId to something. Attempt to set it back to null.

Relevant Code:

auth.setTenantId(null);

Details

flutterfire issue: firebase/flutterfire#7896 (comment)

@google-oss-bot
Copy link
Contributor

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@lisajian
Copy link

lisajian commented Feb 3, 2022

Hi, thanks for filing this issue! We are unable to promise any timeline for this, but if others also have this issue, adding a +1 on this issue can help us prioritize adding this to the roadmap.

(Googler-only internal tracking bug: b/217762163)

@stee1ix
Copy link

stee1ix commented Mar 20, 2024

I am facing this issue as well. Any solutions or workarounds? @Rexios80

@Rexios80
Copy link
Author

We made a public tenant

@stee1ix
Copy link

stee1ix commented Mar 21, 2024

@lisajian @Rexios80 Can you explain a bit more please

@stee1ix
Copy link

stee1ix commented Mar 26, 2024

@Rexios80 Whats a public tenant?

@Rexios80
Copy link
Author

Instead of having users with no tenant id, we just made sure everyone has a tenant

@stee1ix
Copy link

stee1ix commented Jul 4, 2024

Hi, thanks for filing this issue! We are unable to promise any timeline for this, but if others also have this issue, adding a +1 on this issue can help us prioritize adding this to the roadmap.

(Googler-only internal tracking bug: b/217762163)

+1 Please make this a feature

@stee1ix
Copy link

stee1ix commented Jul 4, 2024

@lisajian Any updates on this?

@Rexios80
Copy link
Author

Rexios80 commented Jul 4, 2024

All it would take is modifying this method in the Android SDK:

    public void setTenantId(@NonNull String var1) {
        Preconditions.checkNotEmpty(var1);
        synchronized(this.zzj) {
            this.zzk = var1;
        }
    }

It looks like all that needs done is removing the @NonNull annotation and the Preconditions.checkNotEmpty(var1) check. That checks if the value is null or empty. It should be replaced with just an empty check if the value is not null.

Obviously I can't see the actual Android SDK code so I can't know for sure if it's that easy, but the tenant id starts out null so I see no reason these extraneous null checks aren't the only roadblock to setting it back to null.

I don't see how this could possibly take over 2 years to implement. What is going on over there? The iOS and web SDKs already allow this so it's not a new feature or something.

@ArunGovil
Copy link

Hi, thanks for filing this issue! We are unable to promise any timeline for this, but if others also have this issue, adding a +1 on this issue can help us prioritize adding this to the roadmap.

(Googler-only internal tracking bug: b/217762163)

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants
@Rexios80 @lisajian @google-oss-bot @ArunGovil @stee1ix @argzdev and others