-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Export error classes #2151
Conversation
Would love to see this added, it doesn't appear there's another way to easily access the error types from this package? |
I agree this is needed and follows the standard JS pattern for checking for a particular error. Error handling is important to good quality code and this library needs to support that also. @IchordeDionysos this has got out of data with the base branch may need an update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @IchordeDionysos ! LGTM!
Discussion
Expose the
FirebaseError
classes to enable code like this:Testing
API Changes
us make Firebase APIs better, please propose your change in an issue so that we
can discuss it together.