Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase-admin 8.3.0 causes npm install warnings #614

Closed
jhuleatt opened this issue Aug 7, 2019 · 4 comments · Fixed by #635
Closed

firebase-admin 8.3.0 causes npm install warnings #614

jhuleatt opened this issue Aug 7, 2019 · 4 comments · Fixed by #635
Assignees

Comments

@jhuleatt
Copy link
Contributor

jhuleatt commented Aug 7, 2019

Describe your environment

  • Operating System version: Mac OS
  • firebase-admin SDK version: 8.3.0

Describe the problem

Running npm install with firebase-admin as a dependency results in the following warnings:

npm WARN @firebase/[email protected] requires a peer of @firebase/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @firebase/[email protected] requires a peer of @firebase/[email protected] but none is installed. You must install peer dependencies yourself.
npm WARN @firebase/[email protected] requires a peer of @firebase/[email protected] but none is installed. You must install peer dependencies yourself.

I believe this is caused by this change in 8.3.0:

Downgraded the dependency on the @firebase/app package to a dev dependency.

Steps to reproduce:

Clone the functions-samples repo, navigate to the functions dir of big-ben, and run npm install [email protected]

@google-oss-bot
Copy link

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not seem to follow the issue template. Make sure you provide all the required information.

@hiranya911
Copy link
Contributor

Possible options under consideration:

  1. Remove the peer dependency
  2. Introduce a new database package specifically for this use case (@firebase/database-standalone)

@jhuleatt jhuleatt changed the title @firebase/app as dev dependency causes npm install warnings firebase-admin 8.3.0 causes npm install warnings Aug 9, 2019
@Jeremywhiteley
Copy link

I ran to get around it.
npm install @firebase/app
npm install @firebase/app-types

Then ran install npm install

@hiranya911
Copy link
Contributor

Yes, this happened because we downgraded the dependency on @firebase/app to a dev dependency. The @firebase/database package is designed to work without @firebase/app, but it still declares a peer dependency on it. The JS SDK team (@Feiyang1 et al) are already on the case. In the meantime, you're free to ignore the warning. I don't think there are any negative consequences.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants