-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion: rename app.delete() #489
Comments
I found a few problems with this issue:
|
Renaming this is not an option. All our SDKs support this method (even the client SDKs), and a rename would be a massive breaking change. But we can add more details to the existing documentation.
|
Hi @egilmorez. Lets make this clear in the new documentation you're currently working on. |
@egilmorez there are some other places in the documentation that are vague in a similar fashion. If you come across any "instance" in the text, please check if it's explicit what that points to. I get the feel that for the authors these things have been over clear, and the right context is often assumed from the reader. |
I'm going to close this as I don't see any immediate action items for this repo. As for the naming change suggested, unfortunately the |
Would it fit the scope and design of Personally, |
|
FWIW it's very confusing. Every developer running into this will have to wonder: does it cleanup the local background tasks or delete the production database entirely?
The documentation does not help either.
By app does it mean the app object I initiated locally or does it mean the production database (used to be called Firebase App)?
Please consider a common alternative, such as
disconnect
.Related to #91 (comment)
The text was updated successfully, but these errors were encountered: