Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing against Node 8 and 9 #153

Closed
ofrobots opened this issue Dec 6, 2017 · 5 comments
Closed

Start testing against Node 8 and 9 #153

ofrobots opened this issue Dec 6, 2017 · 5 comments

Comments

@ofrobots
Copy link
Contributor

ofrobots commented Dec 6, 2017

Hi Folks, over at my PR (#265) I noticed that the tests are run against Node 4, 5, 6, 7. Is there a reason for not testing against the actual LTS and Current releases (8.x and 9.x respectively).

BTW, Node 5 and 7 are no longer supported upstream. You can stop testing against those.

@hiranya911
Copy link
Contributor

@jshcrowthe WDYT?

@firebase firebase deleted a comment from google-oss-bot Dec 8, 2017
@firebase firebase deleted a comment from google-oss-bot Dec 8, 2017
@hiranya911
Copy link
Contributor

I actually got a test failure on Node 9: https://travis-ci.org/firebase/firebase-admin-node/builds/313726251

@hiranya911
Copy link
Contributor

Testing on Node 8 is now in place.

@hiranya911
Copy link
Contributor

Closing this since we have Node 8 CI set up now. We can add Node 9 in the future.

@ofrobots
Copy link
Contributor Author

Is there rationale for not starting to test against Node 9 immediately? Node 9 is the "current" version of Node, and as you can see from the charts here, Node 9 is already has significant usage.

Either way, I don't believe you've adequately addressed the original issue I opened that requested testing on both 8.x and 9.x. Either this bug should be reopened, or you should open another bug to track the addition of Node 9.x, if you're not going to address it immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants