-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start testing against Node 8 and 9 #153
Comments
@jshcrowthe WDYT? |
I actually got a test failure on Node 9: https://travis-ci.org/firebase/firebase-admin-node/builds/313726251 |
Testing on Node 8 is now in place. |
Closing this since we have Node 8 CI set up now. We can add Node 9 in the future. |
Is there rationale for not starting to test against Node 9 immediately? Node 9 is the "current" version of Node, and as you can see from the charts here, Node 9 is already has significant usage. Either way, I don't believe you've adequately addressed the original issue I opened that requested testing on both 8.x and 9.x. Either this bug should be reopened, or you should open another bug to track the addition of Node 9.x, if you're not going to address it immediately. |
Hi Folks, over at my PR (#265) I noticed that the tests are run against Node 4, 5, 6, 7. Is there a reason for not testing against the actual LTS and Current releases (8.x and 9.x respectively).
BTW, Node 5 and 7 are no longer supported upstream. You can stop testing against those.
The text was updated successfully, but these errors were encountered: