Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [fs-bq-export] README fails to mention "Enable Events" #2273

Open
gregfenton opened this issue Feb 2, 2025 · 1 comment
Open

🐛 [fs-bq-export] README fails to mention "Enable Events" #2273

gregfenton opened this issue Feb 2, 2025 · 1 comment
Labels
blocked Blocked by an outstanding issue or PR documentation Improvements or additions to documentation type: bug Something isn't working

Comments

@gregfenton
Copy link
Contributor

  • Extension name: firestore-bigquery-export
  • Extension version: 0.1.57

The README mentions the meaning of each option presented during execution of firebase ext:update except for the very last one: "Enable Events". This is in the README at the end of the section *** Configuration Parameters***, just before the section Cloud Functions.

When running that command the final prompt has the text:

Enable Events: If you enable events, you can write custom event handlers
(https://firebase.google.com/docs/extensions/install-extensions#eventarc) that respond to these events.

You can always enable or disable events later. Events will be emitted via Eventarc. Fees apply
(https://cloud.google.com/eventarc/pricing).

? Would you like to enable events? (y/N)

@gregfenton gregfenton added the type: bug Something isn't working label Feb 2, 2025
@cabljac cabljac added the documentation Improvements or additions to documentation label Feb 11, 2025
@cabljac
Copy link
Contributor

cabljac commented Feb 11, 2025

Thanks for opening this! The README are currently generated automatically from extension.yaml and the PREINSTALL.md, so this will require an update to the script we use.

Good spot!

@cabljac cabljac added blocked Blocked by an outstanding issue or PR and removed blocked Blocked by an outstanding issue or PR labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by an outstanding issue or PR documentation Improvements or additions to documentation type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants