Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making COOKIE_SECRET an env var #690

Open
kulp006 opened this issue Aug 14, 2024 · 5 comments
Open

making COOKIE_SECRET an env var #690

kulp006 opened this issue Aug 14, 2024 · 5 comments
Assignees
@Aditya-PS-05
Labels
hacktoberfest

Comments

@kulp006
Copy link

kulp006 commented Aug 14, 2024 •
edited
Loading

make COOKIE_SECRET an env var instead of checking in proxy.config.json

git-proxy/proxy.config.json

Line 3 in fd63848

"cookieSecret": "cookie secret",

@JamieSlome
Copy link
Member

Thanks for creating the issue @kulp006. Can you explain what your requirement is or why you think this should be the case?

@coderhs
Copy link

coderhs commented Oct 3, 2024 •
edited
Loading

I am guessing the recommendation to use ENV variable is to make sure that new installations changes it. I can work on it if the request is still valid.

@Aditya-PS-05
Copy link

Can you assign me this task?

@JamieSlome
Copy link
Member

@Aditya-PS-05 - sure!

@Aditya-PS-05 Aditya-PS-05 mentioned this issue Oct 23, 2024
Closed
@Aditya-PS-05
Copy link

@JamieSlome , Please review my pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aditya-PS-05 Aditya-PS-05

Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add cookie secret env var Aditya-PS-05/git-proxy
4 participants
@coderhs @JamieSlome @Aditya-PS-05 @kulp006