You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In CDM, there is the function Create_AcceptedWorkflowStepFromInstruction under cdm.event.workflow:func for creating default accepted workflow steps. This function is currently being used in DRR, along with an analog function for the cancelled workflow steps, Create_CancelledWorkflowStepFromInstruction, which is located in DRR.
Proposal
Our proposal is to migrate the Create_CancelledWorkflowStepFromInstruction function from DRR to CDM, since it fits the cdm.event.workflow:func namespace better and allows to have all these workflowStep functions located in a single place in CDM, while also making it available for CDM-only usage if necessary.
Compatibility
Since this contribution would just include a new function in CDM, there are no issues with compatibility.
For DRR, once DRR is updated to have the latest CDM version, the original function should be removed to avoid code duplication.
ebataller
changed the title
Proposed Create_CancelledWorkflowStepFromIntruction function migration to CDM
Proposed Create_CancelledWorkflowStepFromInstruction function migration to CDM
Oct 24, 2024
Background
In CDM, there is the function
Create_AcceptedWorkflowStepFromInstruction
undercdm.event.workflow:func
for creating default accepted workflow steps. This function is currently being used in DRR, along with an analog function for the cancelled workflow steps,Create_CancelledWorkflowStepFromInstruction
, which is located in DRR.Proposal
Our proposal is to migrate the
Create_CancelledWorkflowStepFromInstruction
function from DRR to CDM, since it fits thecdm.event.workflow:func
namespace better and allows to have all these workflowStep functions located in a single place in CDM, while also making it available for CDM-only usage if necessary.Compatibility
Since this contribution would just include a new function in CDM, there are no issues with compatibility.
For DRR, once DRR is updated to have the latest CDM version, the original function should be removed to avoid code duplication.
PR: #3195
The text was updated successfully, but these errors were encountered: