Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Create_CancelledWorkflowStepFromInstruction function migration to CDM #3194

Closed
ebataller opened this issue Oct 22, 2024 · 1 comment

Comments

@ebataller
Copy link
Contributor

ebataller commented Oct 22, 2024

Background

In CDM, there is the function Create_AcceptedWorkflowStepFromInstruction under cdm.event.workflow:func for creating default accepted workflow steps. This function is currently being used in DRR, along with an analog function for the cancelled workflow steps, Create_CancelledWorkflowStepFromInstruction, which is located in DRR.

Proposal

Our proposal is to migrate the Create_CancelledWorkflowStepFromInstruction function from DRR to CDM, since it fits the cdm.event.workflow:func namespace better and allows to have all these workflowStep functions located in a single place in CDM, while also making it available for CDM-only usage if necessary.

Compatibility

Since this contribution would just include a new function in CDM, there are no issues with compatibility.

For DRR, once DRR is updated to have the latest CDM version, the original function should be removed to avoid code duplication.

PR: #3195

@ebataller ebataller changed the title Proposed Create_CancelledWorkflowStepFromIntruction function migration to CDM Proposed Create_CancelledWorkflowStepFromInstruction function migration to CDM Oct 24, 2024
@manel-martos
Copy link
Contributor

Closing this issue as the cancellation of the original PR was accepted during the [January 21st CDM Contribution Review WG](#3310).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants