-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linker errors #50
Comments
Hi there!
At the time when working on the last release of S4AHK I did not have VS installed at all, and did not wish to install a big (~10GB) software package on my computer. An interesting thing about msys2/clang64 is that it uses the latest official C runtime library (aka Universal C Runtime) unlike previous gcc based Windows compilers, which used the old msvcrt.dll.
Full disclosure: I don't actually have/want/need Mercurial either. I'm internally using a git-hg bridge to make my life easier, but I decided to give instructions pointing to the official hg repos in order to rely on vanilla upstream as much as possible, and also to simplify future three-way merges when it is time to move to a new SciTE release.
The linked StackOverflow thread combined with my previous disclosure might explain why it worked for me locally when testing the instructions, but not for others. Good catch, I will replace it with the
As you may have guessed, I did not pay attention to the NMake/MSVC path of the buildsystem. I've checked the diff and (other than autogenerated changes) apparently I left a rule for MessagePump.obj; I suspect this was a leftover of an older patch of mine I applied. Given that the changes required to restore buildability with NMake/MSVC seem minimal, I have no objections to fixing this. I'm leaving this issue open as a self-reminder. |
Yes, although only after I worked out that Initially I found the
Incidentally, I am not using Visual Studio itself with SciTE. I believe you can just install the Visual Studio Build Tools; I read as much while configuring VS Code to build and debug SciTE. |
Full disclosure: I am not using the "prerequisite" setup described in the readme.
I was unable to apply the diffs using
git apply
as instructed; Git apply patch fails silently (no errors but nothing happens). I usedpatch -p1 < whatever.diff
instead. This appears to have applied the patch without errors.The linker failed to resolve some symbols:
SHLWAPI.LIB
is missing from the import libs.MessagePump.obj
is missing from the dependencies (SHAREDOBJS) in scite.mak.After fixing those issues, I was able to build using the following batch script, invoked from a VS Code Task:
The text was updated successfully, but these errors were encountered: