Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some menu items and options in the navigation toolbar don't work #4211

Closed
winston-de opened this issue Mar 22, 2021 · 7 comments · Fixed by #4227
Closed

Some menu items and options in the navigation toolbar don't work #4211

winston-de opened this issue Mar 22, 2021 · 7 comments · Fixed by #4227

Comments

@winston-de
Copy link
Contributor

winston-de commented Mar 22, 2021

Explain the bug
Write a clear description of what the bug is.

To reproduce

  1. Go to any folder
  2. Open selection flyout, click on select all
  3. Nothing happens
  4. Repeat for all other options in flyout with same result

Expected behavior
The flyout items should perform their tasks.

Logfile
Nothing relevant.

Screenshots

8mb.video-72d-UkwdqWHR.mp4

System Information

  • OS Version: 21337.1010
  • App version: 1.4.47.0

Additional comment
Restart does not fix.
The keyboard shortcuts, however, do still work.

@winston-de winston-de added the bug label Mar 22, 2021
@yaira2
Copy link
Member

yaira2 commented Mar 22, 2021

@winston-de I can't reproduce this issue on my end.

@winston-de
Copy link
Contributor Author

@yaichenbaum I can reproduce this in both the stable version and in the latest version of main. I'll see if I can debug it.

@winston-de
Copy link
Contributor Author

This issue does not actually seem to be limited to the selection options, new tab, new window, and new pane in the ... menu are not working either. Changing the toggles for show file extensions and show hidden items in the display options flyout dont work either.
It looks like the issue is that none of the RelayCommands are getting fired when a flyout item is pressed, but I don't know much more. I'll look more into it in the morning.

@winston-de winston-de changed the title None of the selection options work Some menu items and options in the navigation toolbar don't work Mar 22, 2021
@yaira2
Copy link
Member

yaira2 commented Mar 22, 2021

@winston-de I was able to reproduce it with the latest changes.

@winston-de
Copy link
Contributor Author

winston-de commented Mar 22, 2021

It looks like this worked pre-#4189.
fyi @d2dyno1

@d2dyno1
Copy link
Member

d2dyno1 commented Mar 22, 2021

when-1 @winston-de Thanks for the report. I'll look into it. Is there anything more broken besides this?

@winston-de
Copy link
Contributor Author

@d2dyno1 There's a few other things, but they appear to have been broken before your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants