-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code base: Rewriting/improving the FullTrustProcess #2794
Comments
@yaichenbaum @duke7553 correct if I'm wrong: I understood that the plan is to switch sometimes in the future to using net5 + winui desktop. We could anyway check if there is any performance gain in loading the context menu (this is the most noticeably slow part of the Fulltrust process) by switching to c++ |
@gave92 We haven't made any decision around that yet, it's going to be quite a while before WinUI Desktop is going to be ready for us to use and even then, we don't know what the full story will be. Taking that into account, if we were to make the switch, it won't be for a while and I wouldn't like that to hold us back on improving what we have now. That being said, if sticking with c# will make it easier to move over to WinUI Desktop in the future, then we should instead work on reducing the memory usage of the current code. |
Not for the faint of hearts: In case someone else wants to get his/her hands dirty.. contributions are welcome :) What works @10/01/2021:
|
Wooow @gave92!! |
For #4180 |
@gave92 Did we want to continue this or was the plan to wait for WinUI Desktop? |
Is your feature request related to a problem? Please describe.
The current FullTrustProcess does what it's meant to do, but the code base is kind of messy and hard to work with, additionally, it uses more system resources than a project of this size should.
Describe the solution you'd like
Rewriting the FullTrustProcess seems likely to happen at this point, while it doesn't need to be done in c++, once the effort is being made, using c++ might be a good choice in order to squeeze the maximum performance that we can while using as little system resources as possible.
Describe alternatives you've considered
Improving the current code for this process to use better practices and to try to reduce the memory usage.
The text was updated successfully, but these errors were encountered: