-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Support custom args for actions #15141
Comments
A good use case for this is applying custom tags (see #11352) |
One thing to consider is how to handle validation. Should there just be a TextBox for inputting args or should it be more specific (eg. a dropdown with a list of tags)? |
The latter should be more secure but needs to store a collection(it won' be a big deal I assume). |
Secure as in making sure it's a valid arg? |
Yes. If it's just a TextBox we don't have a way to notify user of syntax errors and user would be confused why it doesn't work. |
This feature would be targeting advanced users but it's still something to consider. |
We've discussed this internally and we're leaning towards including validation, we will probably need the following types, but they can be added as needed.
|
Great idea. I thought it was nice to have selector box but we cannot list up every file extension. It might be better to use AutoSuggestBox, validate input and show errors if any, like a Branch selector in GitHub(it enables me to select or create it if doesn't exist). In current implementation of Actions makes us hard to implement error handling like above but we can use hot key editor dialog, put the parameter text box into that, show error text in red like a password box of web auth (like Google Login), after settings tabs done. For file extensions, doesn't need to validate but for tags or even username we might have to check if it exists and show errors or warnings(maybe don't have to prevent?). |
I think for file extensions it would only need to make sure there are no spaces or unsupported characters in the text field.
I was thinking along the same lines... |
What feature or improvement do you think would benefit Files?
With the introduction of custom key-bindings in version 3.4, it's a good time to start considering how we want to implement support for custom arguments in actions.
Requirements
{CurrentDirectory}
)Use cases for this feature
Files Version
v3.3
Windows Version
Windows 11
Comments
No response
The text was updated successfully, but these errors were encountered: