Bug: Not a folder error when opening recycle bin from shortcut

[ElCunq]

Important

Current workaround - Backup your settings in Files settings > Advanced > Export, then reinstall Files.

Description

I can't use the app after the last updates. It says "NotAFolder" when I try to open trash bin or ThisPC.

Steps To Reproduce

Restart computer.
Try to open trashbin or ThisPC.
Get the error.

Requirements

Normally it should open the files but it doesn't open. I can solve it using preview version with it but it's temporary.

Files Version

3.3.0.0

Windows Version

10.0.22631.3296

Log File

debug.log

[Josh65-2201]

Thanks for the report, have you tried reinstalling Files?
Make sure to export your settings by going to Files settings > Advanced > Export. then Import your settings from Files settings > Advanced > Import after reinstalling.

[ElCunq]

Thanks for the report, have you tried reinstalling Files? Make sure to export your settings by going to Files settings > Advanced > Export. then Import your settings from Files settings > Advanced > Import after reinstalling.

Yes I tried like 3 or 4 times both stable and preview but it didn't work. Almost all my settings same with standart so I didn't exported them. But I remember I just change preview to acrylic and "set files for default file manager" to on.

[Josh65-2201]

What's shown in the path bar?

[ElCunq]

Shell:RecycleBinFolder and Shell:MyComputerFolder this two
Oh and the quick access part on home shows empty with this bug.

[ElCunq]

for again this is the recyclebin

and this is the home screen

[T-i-a-7]

Same problem here.

[ElCunq]

2 weeks later still no progress. That's sad.

[Josh65-2201]

There still hasn't been a way to constantly reproduce this, Only you and T-i-a-7 have reported it. Unfortunately there no error in the log to go off either.

[ElCunq]

I'm using kaspersky as a antivirus. Can it cause to problem? @T-i-a-7 are you using same?

[T-i-a-7]

@ElCunq @Josh65-2201 No, I'm not using it so that is not the problem.
I would also like to tell you that I did a clean install of windows (for another reason, not for this problem) and reinstalled Files as well. Guess what?! Everything is fine now: installed the same way, configured the same way, everything the same but now magically it works.

[TCAtrevor]

I am seeing this issue on one computer, but not the other, although I could've sworn it used to be on both. The currently affected computer has a largely filled Recycle Bin and the one no longer having this issue is currently empty. Hope this is relevant. I should've searched this issue sooner to give my feedback.

[Josh65-2201]

Does reinstalling Files on the one showing the dialog fix it?

[ElCunq]

Does reinstalling Files on the one showing the dialog fix it?

Nope it didn't fix it. Actually it made no help. I thought it'll make some fixes but none. 🥲

[ElCunq]

I am seeing this issue on one computer, but not the other, although I could've sworn it used to be on both. The currently affected computer has a largely filled Recycle Bin and the one no longer having this issue is currently empty. Hope this is relevant. I should've searched this issue sooner to give my feedback.

Thanks for the feedback I hope it'll help to solve

[vchalmel]

Hello, I have the same issue here.

Using the "Reinitialize" button from the "Apps & Features" >> "advanced options" control panel "solved" it tho.
@ElCunq you could try that after backuping all the app temp & config files and inspect those with the team to find the discrepancy. Maybe they can find where is the issue by restoring favs and configs options one by one.

[justinlosh]

I'm having the same issue, but not much in the debug log with the exception of the following:

2024-06-12 19:28:08.4616|Error|System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'ObjectReference'.
   at WinRT.IObjectReference.ThrowIfDisposed()
   at WinRT.IObjectReference.AsType[T]()
   at WinRT.ExceptionHelpers.GetHRForException(Exception ex)
   at ABI.System.EventHandler`1.Do_Abi_Invoke[TAbi](Void* thisPtr, IntPtr sender, TAbi args)

Afterwards, the "Recycle Bin" shows as "Shell:RecycleBinFolder" in the Pinned file tree.

[ElCunq]

I had to reinstall windows some other problems and it didn't happen again but İ'm scared of it to repeat. I hope it'll be solved soon

[justinlosh]

Yeah, I actually just reinstalled Win 11 a week ago.

[0x5bfa]

the quick access part on home shows empty with this bug.

@ElCunq Let me know what makes you think so?

[0x5bfa]

Thank for you all five people reporting this issue and waiting it to be fixed with great patience.

While Files devs have never been able to reproduce this, what I can tell is enumeration goes wrong without exception but with an unknown error when converting string path (‘Shell:RecycleBinFolder’).

I’m pretty sure this dialog with humanized error code is used only in this place in single method for enumerating inner children:

Files/src/Files.App/Data/Models/ItemViewModel.cs

Line 1657 in 31d6fee

await DialogDisplayHelper.ShowDialogAsync("DriveUnpluggedDialog/Title".GetLocalizedResource(), "");

This error message is actually ERROR_INVALID_DRIVE error from HResult. ‘NotAFolder’ message isn’t appropriate at all. So I will log to know until next preview build (also next stable is coming soon v3.5).

Files/src/Files.App/Utils/Storage/Helpers/FilesystemTasks.cs

Line 48 in 31d6fee

return new FilesystemResult<T>(default, GetErrorCode(ex, typeof(T)));

@yaira2 @hishitetsu fyi let me know it’d make us easy to investigate.

When preview build with this modification published, I’d like you all to paste log here.

[hishitetsu]

Is there any possibility of a timeout?

Files/src/Files.App/Data/Models/ItemViewModel.cs

Line 1616 in 31d6fee

.WithTimeoutAsync(TimeSpan.FromSeconds(5));

[TCAtrevor]

This issue is certainly not resolved. I have still received this message on both 3.6 and now 3.7.

[yaira2]

How do you reproduce the bug? I created a shortcut as described and it works fine.

[TCAtrevor]

I'm not sure how it is reproduced. It seems like it's been a mystery for everyone else experiencing it too. I can provide my config if there's any chance that helps, but from my perspective, it's just a random on-and-off issue between my two computers.

[yaira2]

How are you accessing Recycle Bin, via the Sidebar?

[TCAtrevor]

Recycle Bin does not show up on the sidebar for me. I access it from the desktop icon provided by default on Windows.

[T-i-a-7]

@yaira2 As mentioned above, this bug is not currently reproducible. It occurs when the user opens the recycle bin using the icon on the desktop, but for some reason this bug does not happen all the time and for every user. Therefore, it is difficult to reproduce it.

[yaira2]

Is Files set as the default file manager?

[T-i-a-7]

Yes, but the bug occurs even when this setting is turned off.

[yaira2]

How do you reproduce the issue when Files is not the default file manager?

[T-i-a-7]

If I remeber correctly (The bug is not happening to me at the moment), you reproduce it by typing the bin directory (wich I don't remeber) directly in Files when it is not set as default. But I could be wrong.

[yaira2]

I can't reproduce by entering Shell:RecycleBinFolder into the path bar, but I'll reopen this issue in case someone has a more reliable way to repro this.

[TCAtrevor]

I found another interesting workaround for this situation. If you drag the tab of the new window into an existing one, it is able to load.

2024-09-08.10-42-40.mp4

[T-i-a-7]

Yes, it also does the same thing by changing the language in Files' settings

[Illustar0]

The same problem happened to me. Unfortunately, I couldn't find a way to reproduce it stably. But maybe you could try to modify the "Startup Settings"?

[Illustar0]

For me, this problem occurred after I modified the "Startup Settings", and I can reproduce it stably

[yaira2]

For me, this problem occurred after I modified the "Startup Settings", and I can reproduce it stably

What did you set your settings to?

[Illustar0]

For me, this problem occurred after I modified the "Startup Settings", and I can reproduce it stably

What did you set your settings to?

1. Change "Startup Settings" to "Open New Tab"
2. Close Files
3. Open Files
4. Problem occurs

OK. I was able to reproduce the problem this way yesterday (and it still worked after reinstalling Files), but it doesn't work today. This is a really weird problem.

[Illustar0]

The only thing that is certain at the moment is that reinstalling Files can temporarily solve this problem, but you never know when it will happen again for what reason.

[Illustar0]

It's amazing. The problem just went away. I didn't do anything, but it just got better.

[Guiruo]

This problem still exists in the Files 3.7.7.0, but strangely, after reinstalling the Windows system, the problem of this drive popping up still exists. I can't determine where the problem is, but I can confirm that it is most likely not the problem of Files. I have used Windows To Go to test multiple computers, and Files are all working normally, without exception. If you use the Win + E shortcut to open the home page of Files, not the drive page. When you open this computer again, Recycle Bin, Network, etc., the folder with the Shell pin can be used normally. This is the strange problem. Of course, the system I tested is: Windows 11 Professional Workstation Edition 23H2 Build 22631.3737 The version of Files is: Files 3.7.7.0

[Guiruo]

目前唯一可以确定的是，重新安装 Files 可以暂时解决这个问题，但您永远不知道它何时会因什么原因再次发生。

The problem arises when, after reinstalling Files, if you disable the background permissions for Files and then perform a cold start, it still shows a NotAFolder error. This issue cannot be located in the logs, which is quite strange and seems to be a problem with the Windows system.

[Guiruo]

It's amazing. The problem just went away. I didn't do anything, but it just got better.

This is merely a temporary disappearance of the issue, not a resolution. You never know how or when this problem will reoccur.

[Illustar0]

It's amazing. The problem just went away. I didn't do anything, but it just got better.

This is merely a temporary disappearance of the issue, not a resolution. You never know how or when this problem will reoccur.

I know. But it's really amazing, isn't it? We can't locate the problem, or even reproduce it stably.