Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Use RichCommand for widget items #14760

Open
0x5bfa opened this issue Feb 18, 2024 · 0 comments
Open

Code Quality: Use RichCommand for widget items #14760

0x5bfa opened this issue Feb 18, 2024 · 0 comments
Assignees

Comments

@0x5bfa
Copy link
Member

0x5bfa commented Feb 18, 2024

Description

Widget pages have a very complicated codebase such as hooking events in Home page triggered in each widgets. I think this is because of associatedInstance but we can simplify it. In my search, achieving this goal will reduce about 500 lines. To be simple, I splitted up the work.

Concerned code

  • Widget controls
  • Home page
  • Actions

Gains

  • Far better maintainability

Requirements

Stage 1 (Done) (approx. 1200 lines)

  • Introduce view models to widget controls

Stage 2 (Done) (approx. 150 lines)

  • Remove events in Home and let widget view models handle them

Stage 3 (In Progress) (approx. 500 lines)

  • Replace ICommands with RichCommands

Stage 4 (Ready) (approx. 100 lines)

  • Fix some bugs around refresh button and automatic refresh

Comments

No response

@0x5bfa 0x5bfa self-assigned this Feb 18, 2024
@Josh65-2201 Josh65-2201 changed the title Code Quality: Intorduce view models to widget controls Code Quality: Introduce view models to widget controls Feb 18, 2024
@Josh65-2201 Josh65-2201 moved this from 🆕 New to 🏗 In progress in Files task board Apr 30, 2024
@0x5bfa 0x5bfa changed the title Code Quality: Introduce view models to widget controls Code Quality: Use RichCommand for widget items May 13, 2024
@0x5bfa 0x5bfa removed their assignment Nov 14, 2024
@yaira2 yaira2 closed this as completed Nov 14, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Nov 14, 2024
@yaira2 yaira2 reopened this Nov 15, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 🆕 New in Files task board Nov 15, 2024
@yaira2 yaira2 self-assigned this Nov 15, 2024
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Nov 15, 2024
@yaira2 yaira2 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants