Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Don't install all selected fonts at once #13922

Closed
ggtylerr opened this issue Nov 17, 2023 · 3 comments · Fixed by #14024
Closed

Bug: Don't install all selected fonts at once #13922

ggtylerr opened this issue Nov 17, 2023 · 3 comments · Fixed by #14024
Labels
crash Bug reports involving a crash

Comments

@ggtylerr
Copy link

ggtylerr commented Nov 17, 2023

Description

When installing multiple fonts, it should not try and install it at all once. Doing this with a large amount of fonts (e.g. with GH's monaspace) causes a couple hundred PS threads to launch, slowing down the system to a crawl.
A screenshot of btop showing the CPU at max usage with a lot of powershell copy-item commands

Steps To Reproduce

  1. Download a large list of fonts to install.
  2. Select them all in files and press install
  3. Watch as your computer explodes

Requirements

  • Don't launch 200 copy-item commands at once.
    • Probably can do one at time, or at most 5-10.
    • Possibly add a progress meter in the status center.

Files Version

3.0.5.0

Windows Version

10.0.22621.2428

Log File

(it crashed and reopened files automatically when I did this, causing the log to wipe)

@ggtylerr ggtylerr added the bug label Nov 17, 2023
@yaira2
Copy link
Member

yaira2 commented Nov 17, 2023

@ggtylerr can you try to repro one more time to try and get the log file?

@yaira2 yaira2 changed the title Don't install all selected fonts at once Bug: Don't install all selected fonts at once Nov 17, 2023
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Nov 17, 2023
@yaira2 yaira2 added the crash Bug reports involving a crash label Nov 17, 2023
@ggtylerr
Copy link
Author

Had to torture my computer a second time but here. I don't see anything relating to the font files here unfortunately.
debug.log

@yaira2
Copy link
Member

yaira2 commented Nov 17, 2023

Either way, the crash is probably caused by all the running processes.

@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Nov 23, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Bug reports involving a crash
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants