Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update layout button icon as layout changes #12894

Closed
mdtauk opened this issue Jul 7, 2023 · 4 comments · Fixed by #12915
Closed

Feature: Update layout button icon as layout changes #12894

mdtauk opened this issue Jul 7, 2023 · 4 comments · Fixed by #12915

Comments

@mdtauk
Copy link
Contributor

mdtauk commented Jul 7, 2023

What feature or improvement do you think would benefit Files?

At the moment, the layout button's icon does not match the current chosen layout from the flyout.

image

Requirements

  • This proposal will allow the user to see what the current layout is being used, and provides a better hint at what this button does, which is unlabelled in the UI

Files Version

2.5.13 Preview

Windows Version

22621.1928

Comments

No response

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Jul 7, 2023
@yaira2
Copy link
Member

yaira2 commented Jul 7, 2023

Thank you for your feedback.

@ferrariofilippo
Copy link
Contributor

When using adaptive layout should we use a specific icon or the one corresponding to the current layout (details or grid)?

@Josh65-2201
Copy link
Member

Josh65-2201 commented Jul 10, 2023

Adaptive mode was turned into a toggle based on the Work in progress discord post Never mind misread the post

@yaira2
Copy link
Member

yaira2 commented Jul 10, 2023

When using adaptive layout should we use a specific icon or the one corresponding to the current layout (details or grid)?

I think we should use the one corresponding to the current layout.

@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Jul 10, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants