Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add support for flattening folders #12367

Open
1 of 4 tasks
Jay-o-Way opened this issue May 16, 2023 · 13 comments
Open
1 of 4 tasks

Feature: Add support for flattening folders #12367

Jay-o-Way opened this issue May 16, 2023 · 13 comments

Comments

@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented May 16, 2023

What feature or improvement do you think would benefit Files?

Would love an option to dissolve or flatten a folder. Placing all the content in the parent folder.
Simply said, it's the opposite of "Create folder with selection" and placing it above or below this entry would make the most sense.
Example:

  • 📁 Parent folder
    • 📄 File A
    • 📁 Sub-folder (target this folder)
      • 📄 File B
      • 🖼 File C

Would give:

  • 📁 Parent folder
    • 📄 File A
    • 📄 File B
    • 🖼 File C

Requirements

  • Add action to command palette for flattening folders when a single folder is selected
  • Conflict prompt should show for conflicting/duplicate files
  • Display progress in status center
  • Enable option when multiple folders are selected

Files Version

2.4.71

Windows Version

Windows 10

Comments

I've seen many, many requests for this in the PowerToys repo, so I know it's something people want.

@yaira2
Copy link
Member

yaira2 commented May 16, 2023

We originally discussed this in #10619 but I think it's worth bringing back the discussion again.

@yaira2 yaira2 changed the title Feature: dissolve or flatten folder Feature: Dissolve or flatten folder May 16, 2023
@yaira2
Copy link
Member

yaira2 commented Sep 21, 2023

I updated the requirements to only include one selected folder. Based on the reception and usage of this feature, we'll consider adding support for additional options.

@yaira2 yaira2 changed the title Feature: Dissolve or flatten folder Feature: Add support for flattening folders Sep 21, 2023
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Sep 21, 2023
@hishitetsu
Copy link
Member

I would like to be more clear on the requirements.

  • Should we also recursively flatten subfolders of the target folder?
  • Should the target folder be deleted after the flattening is complete?

@yaira2
Copy link
Member

yaira2 commented Sep 22, 2023

Should we also recursively flatten subfolders of the target folder?

I can see scenarios where both would make sense, perhaps we can add a modal to let the user choose.

Should the target folder be deleted after the flattening is complete?

That's my understanding.

@hishitetsu
Copy link
Member

perhaps we can add a modal to let the user choose.

How about having each as a separate command?

@yaira2
Copy link
Member

yaira2 commented Sep 24, 2023

If we add additional options, we're going to want a modal either way. An added benefit is that it allows the user to confirm what would otherwise be a destructive action.

@yaira2
Copy link
Member

yaira2 commented Aug 26, 2024

Fyi @tundra

@yaira2 yaira2 moved this from 🏗 In progress to 🔖 Ready to build in Files task board Aug 26, 2024
@smarquespt
Copy link

From a translator POV, is this really what "Flatten" means? I don't have a concrete wording but I think "Flatten" is not the best approach ...
https://dictionary.cambridge.org/dictionary/english/flatten

@yaira2
Copy link
Member

yaira2 commented Aug 27, 2024

It combines the folder structure into a single folder.

@mdtauk
Copy link
Contributor

mdtauk commented Aug 27, 2024

My only issue is about language. Flatten makes me think of unfolding a cardboard box, but I know its about creating a "flat" folder structure.

Some wording closer to "Gather files from subfolders and remove folders" but its a concept that is not easy to explain in a short way - and how you would localise the wording?

@yaira2
Copy link
Member

yaira2 commented Aug 27, 2024

We're limited in space, but we can display a more detailed description in the confirmation prompt.

@Jay-o-Way
Copy link
Contributor Author

I've seen "Dissolve (a) folder(s)" being used and that isn't all too weird to me...

@yaira2
Copy link
Member

yaira2 commented Aug 27, 2024

Personally "Dissolve" sounds like it deletes the folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready to build
Development

No branches or pull requests

5 participants