-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Append Async
to the end of each async method for consistency
#12310
Comments
@itsWindows11 do you want to work on this? |
I'm currently busy with exams and stuff so haven't got much time to work on it unfortunately. Feel free to assign someone else to work on it. |
No worries, it's low priority anyways. I added it to the project board for tracking. |
I will work on this |
@yaira2 I might be able to work on it now this weekend. |
Thanks! |
8 tasks
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Files task board
Oct 20, 2023
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Some of the methods in the codebase have
Async
in the end of the method name for the async task, but most async methods in the entire solution don't end withAsync
, for exampleArchiveHelpers.DecompressArchiveHere
.Concerned code
The entire solution.
Gains
Requirements
Async
to all the async method names, i.e. instead ofpublic Task Do()
, rename topublic Task DoAsync()
.async void
methods keep them as is, don't addAsync
to it.Comments
No response
The text was updated successfully, but these errors were encountered: