Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Application is crashing when changing file permissions #11994

Closed
MeiVinEight opened this issue Apr 6, 2023 · 4 comments
Closed

Bug: Application is crashing when changing file permissions #11994

MeiVinEight opened this issue Apr 6, 2023 · 4 comments
Assignees
Labels
area - properties window Features or bug reports for the file permissions page crash Bug reports involving a crash

Comments

@MeiVinEight
Copy link

MeiVinEight commented Apr 6, 2023

Description

image

Steps To Reproduce

  1. Create a folder and disable inheritance using the windows file manager.
  2. Add a permission principal with only Read and execute access using the windows file manager.
  3. Edit it's access to full control using the Files App in security in properties.
  4. Edit it's access to full control using the Files App in advanced security.
  5. It will report "Something went wrong!" and crashed.

These operations do not seem to reproduce the problem 100%, but the modifyings of folder's access permissions do not take effect,
It seems that it is not just this operation that causes the program to crash.
And it seems not work when edit file/folder's access permissions.

Requirements

  • Fix program crashes caused by some operations.
  • Fix security editing, make it work, such as edit user's permissions.

Files Version

Version: 2.4.61.0

Windows Version

Windows 11 22H2 23424.1000

Log file

debug.log

@MeiVinEight MeiVinEight added the bug label Apr 6, 2023
@MeiVinEight MeiVinEight changed the title Wrong on Wrong on security modifing Apr 6, 2023
@MeiVinEight MeiVinEight changed the title Wrong on security modifing Wrong on security modifying Apr 6, 2023
@Josh65-2201
Copy link
Member

There are known issues being tracked in #11549, #11550 and #11551. I assume these are the things you are trying to edit in Files

@Josh65-2201 Josh65-2201 added the needs - additional info Needs more information from the reporter label Apr 6, 2023
@yaira2
Copy link
Member

yaira2 commented Apr 9, 2023

Fyi @0x5bfa

@yaira2 yaira2 changed the title Wrong on security modifying Bug: Application is crashing when changing file permissions Apr 9, 2023
@0x5bfa
Copy link
Member

0x5bfa commented Apr 9, 2023

To make things more clear, I’m planning the following to do:

  • Add a ViewModel for SecurityAdvancedPage.
  • Remove UI-related parts from Filesystem.Security.AccessControlEntry class
  • Remove the code using the default C# security classes
  • Use Win32API by using Vanara possibly

Current security-related codes are a little messy. I’ll find the way.

@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label May 8, 2023
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board May 8, 2023
@0x5bfa 0x5bfa self-assigned this Oct 23, 2023
@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Oct 24, 2023
@yaira2 yaira2 added area - properties window Features or bug reports for the file permissions page crash Bug reports involving a crash labels Oct 25, 2023
@Josh65-2201 Josh65-2201 moved this from 🏗 In progress to 🔖 Ready to build in Files task board Apr 8, 2024
@0x5bfa
Copy link
Member

0x5bfa commented May 13, 2024

I'm sorry but the feature is disabled for a year because of its instability. So we can now close and have to implement the feature to edit file permission. I can start working on from my previous try.

@0x5bfa 0x5bfa closed this as completed May 13, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - properties window Features or bug reports for the file permissions page crash Bug reports involving a crash
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants