Bug: Grouping by tags doesn't show all items, even if they're tagged

[rafaskb]

Description

I have a folder that contains 11 shortcuts to other relevant folders and files (sort of my own quick access thing). I gave 8 of them a certain Tag I just created, and for one of them another tag.
When I select "Group By > Tags", however, only 3 items are shown, under the first tag, and all others are completely hidden.
On top of that, if I select "Refresh", then all items are gone until I remove the "Group By" option.

I'm running Files v, and Windows v10.0.19044.2728

Group.By.Tags.mp4

Steps To Reproduce

1. Open a folder with files inside.
2. Give them some tags
3. Group them by tags
4. All files should show up (even the untagged ones), but instead just some of them are.

Requirements

• Fix some files being hidden by the "Group By > Tags" option, regardless of their tags.
• Fix "Refresh" action following the steps above hiding all items in the folder.

Files Version

Files version 2.4.40.0, OS version 2.4.40.0

Windows Version

Windows 10 Pro Version, 21H2, OS build 19044.2728

Log file

debug.log

[yaira2]

Where are the items? Is this an NTFS drive?

[ferrariofilippo]

@yaira2 this bug is caused by two things:

• Items enumeration stops when an item belongs to no group. In this case, the 4th file is untagged, it would belong to no groups, and the enumeration stops there. We can fix this by adding an Untagged group
• The second issue is that tags are loaded afterwards when the items are shown. When the items are enumerated for the first time, none will have tags assigned. Because they do not have any tag, enumeration will stop immediately, and no item will be shown. If we added the Untagged group then, after refreshing the page, all items would be there

First issue is easy to fix, the second one is more difficult since we should change the way tags are loaded

[ferrariofilippo]

Do you to work on the first?

Done

I feel that the second will require more testing to see if it affects performance.

That's why I said it would be difficult

[rafaskb]

Update

On Files v2.4.60.0 the behavior has changed. Setting the "Group By" option to Tags will properly group everything, even the untagged files (I assume that was issue 1 mentioned by @ferrariofilippo), but refreshing the layout, or reopening the same folder will make all files go under the "untagged" group (which I assume is issue 2 of the above comment).

[ferrariofilippo]

On Files v2.4.60.0 the behavior has changed. Setting the "Group By" option to Tags will properly group everything, even the untagged files (I assume that was issue 1 mentioned by @ferrariofilippo), but refreshing the layout, or reopening the same folder will make all files go under the "untagged" group (which I assume is issue 2 of the above comment).

Yes, that's what I meant

[Josh65-2201]

@rafaskb Can you see if this is an issue in 2.5.21.0

[yaira2]

It's still an issue

[ferrariofilippo]

I'm trying to address this one, but there are a couple of things I'd like to discuss.

1. I see two ways of solving the issue:

   • Load tags and items at the same time. I don't think this is a good idea. It will impact performance, especially in bigger folders.
   • Load all the items and THEN group them. (See video below)
     I'd go with the second option, even if it would show all the items in the Unlabeled group at first.

2. Groups are not updated when tags are changed (context menu, sidebar, preview pane, details view).
   If a user has two tabs/panes showing the same folder, should we update them all at once or only when they are focused? (Edit: this applies to all the grouping/sorting options)

3. It seems that the Tag Labels in the Details View get messed up if items are swapped. Should I open an issue for this? (Edit: Bug: Tag icons in the details layout may use the wrong color #16548)
   To reproduce:
   i. Tag some items (5 or 6)
   ii. Change the sort order
   

Group_Tags.mp4

[AuroraStarstorm]

Potentially related bug I'd like to add but I don't think is unique enough to create its own ticket:

Refreshing folders grouped by tags don't update tags applied since the last "group by" update.

To get new files to move to their categorised group, you have to retrigger the grouping "Group By None" then "Group by Tags".

The tag applies as you can see the associated dot etc, it just doesn't move it to the group.

Unsure if this applies after a restart, but seems unintentional and is frustrating when tidying up.