Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Context menu clipped by the edge of window #11713

Closed
Poker-sang opened this issue Mar 14, 2023 · 8 comments
Closed

Bug: Context menu clipped by the edge of window #11713

Poker-sang opened this issue Mar 14, 2023 · 8 comments
Labels
help wanted Extra attention is needed

Comments

@Poker-sang
Copy link
Contributor

Poker-sang commented Mar 14, 2023

Description

Context menu flyouts could be clip by the edge of the window, when they are placed at the top/bottom of the window, or simply be taller than the window.

O@LKL3D@ZZ3LHIRQON70FMD

@0`B(SYD7KO7XDSZBFUAU R

Steps To Reproduce

Resize the window and right tap anywhere.

Requirements

Fix the bug by limiting the height of the menu or any other ways.

Files Version

2.0.36.0

Windows Version

Windows11 22H2 22621.1265

Log file

debug.log

@Poker-sang Poker-sang added the bug label Mar 14, 2023
@yaira2
Copy link
Member

yaira2 commented Mar 14, 2023

This is a WinAppSdk limitation

@Poker-sang
Copy link
Contributor Author

But Gallery's flyouts would collapse automatically, which looks better I thought?

image

@yaira2
Copy link
Member

yaira2 commented Mar 14, 2023

Which property controls that? It might not be available for the command bar flyout.

@Poker-sang
Copy link
Contributor Author

Which property controls that? It might not be available for the command bar flyout.

Seems you are right. And the issue is caused by CommandBarFlyout.Placement. when it is set to Full, the CommandBarFlyout would exceed the lower boundary of the window
O@LKL3D@ZZ3LHIRQON70FMD

And whatever the value is, it might exceed the left or right boundary. We may have to set Placement to Left or Right manually to fix this bug.

@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Mar 19, 2023
@yaira2 yaira2 added the help wanted Extra attention is needed label Mar 19, 2023
@Lukiluc29
Copy link
Contributor

I too am having a similar problem. For example, when I want to remove the "Tags" category the drop-down menu shows only part
Capture d’écran (10)

@hishitetsu
Copy link
Member

It is now fixed by WASDK 1.4.

@Poker-sang
Copy link
Contributor Author

@hishitetsu Thanks! Can you link if you are convenient?

@yaira2
Copy link
Member

yaira2 commented Aug 30, 2023

@Poker-sang Microsoft hasn't published the changelog yet, but you can test by building the main branch.

@yaira2 yaira2 closed this as completed Aug 30, 2023
@github-project-automation github-project-automation bot moved this from 🔖 Ready to build to ✅ Done in Files task board Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

4 participants