Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Warn the user about invalid tag name #11293

Closed
QuaintMako opened this issue Feb 14, 2023 · 9 comments · Fixed by #11324
Closed

Feature: Warn the user about invalid tag name #11293

QuaintMako opened this issue Feb 14, 2023 · 9 comments · Fixed by #11324
Assignees
Labels
good first issue Good issue for new contributors to get started with

Comments

@QuaintMako
Copy link
Contributor

QuaintMako commented Feb 14, 2023

What feature or improvement do you think would benefit Files?

When entering a name for a tag, some names makes the creation impossible. However, no information is displayed as to why the name is invalid.

The information should be given to the user and so should the reasons too.

Requirements

  • When the name used in the tag box in invalid, write a text underneath the text box to warn the user of the issue.

Files Version

Version 2.4.33.0

Windows Version

W10 Home 22H2 19045.2251

Comments

No response

@yaira2
Copy link
Member

yaira2 commented Feb 14, 2023

What about a text block? I think this is a little less "scary" but still gets the point across.

@yaira2 yaira2 moved this from 🆕 New to 📋 Planning stage in Files task board Feb 14, 2023
@yaira2
Copy link
Member

yaira2 commented Feb 14, 2023

There is already an IsNameValid property, we can use a converter to invert the value and show the textblock when it's false.

@yaira2 yaira2 moved this from 📋 Planning stage to 🔖 Ready to build in Files task board Feb 14, 2023
@yaira2 yaira2 added the good first issue Good issue for new contributors to get started with label Feb 14, 2023
@heftymouse
Copy link
Contributor

Could I work on this?

@Josh65-2201 Josh65-2201 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Feb 18, 2023
@meilluer
Copy link

what makes a tag name invalid?

@yaira2
Copy link
Member

yaira2 commented Feb 24, 2023

If it's a duplicate of another tag name or if the name is blank.

@meilluer
Copy link

using namespace std;

int main() {
string name;

Console.WriteLine("Enter Tag name:");

getline(Console.ReadLine(), name);

if (name.empty()||name.find_first_not_of(' ') == string::npos) {
   Console.WriteLine( "NOT a valid name: tag name either empty or all spaces") ;
}

else if(name="Home","Work","important","photos"){
    Console.WriteLine("NOT a valid name: tag name alrady exist");
}

return 0;

}

this is what i came up with thus far i am having difficulty in incorporating this into program also i want to import all the stored tag names to check if they exist in in else if condition

@Josh65-2201
Copy link
Member

This is already being worked on. You can see the linked pull request and status of this issue.

@meilluer
Copy link

Could I work on this?

hello! are you working on this issue? i would like to contribute my take on this issue but need help, can we connect on discord to futher discuss this issue?

@yaira2
Copy link
Member

yaira2 commented Feb 26, 2023

@meilluer It's already being worked on.

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for new contributors to get started with
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants