Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Slow or stuck file/image preview load time #10983

Closed
Jaluvshuskies opened this issue Jan 11, 2023 · 3 comments · Fixed by #10985
Closed

Bug: Slow or stuck file/image preview load time #10983

Jaluvshuskies opened this issue Jan 11, 2023 · 3 comments · Fixed by #10985

Comments

@Jaluvshuskies
Copy link

Description

Haven't quite narrowed down what the issue could be, but when looking in some folders, the image previews aren't loading and are stuck with the grey preview. See image:
bug

p.s. will add more detail to this when I can, it's late but I wanted to report this

Steps To Reproduce

  1. Open files
  2. Navigate to a folder with files that have previews (png/jpg/mp4)
  3. Observe whether the file previews are shown
  4. Set view type to small icons
  5. Close files
  6. Navigate to the same folder
  7. Observe whether the file previews are shown

Steps to fix

Attempting to figure out what consistent fixes are, however I am unable to find a consistent solution

Here's what I've found so far:

  • Zooming out a few clicks (from small icons to details) instantly fixed the issue once per session. It seem s to sometimes continue to fix when repeating this in the same session
  • Doesn't appear to be drive related (SDD vs HDD)
  • Unsure if related to file type (namely files with previews, like png, jpg, mp4)
  • Happens with different folders, regardless of # of files in it (such as even just 1 image)

Files Version

Version: 2.4.20.0 OS Version: 10.0.19045.2364

Windows Version

Windows 10 22H2 19045.2364

Relevant Assets/Logs

debug.log

@yaira2 yaira2 changed the title Slow or stuck file/image preview load time Bug: Slow or stuck file/image preview load time Jan 11, 2023
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Jan 11, 2023
@yaira2
Copy link
Member

yaira2 commented Jan 11, 2023

This is being caused by the WrapPanel template introduced in #10972

@gave92
Copy link
Member

gave92 commented Jan 13, 2023

IIRC wrap panel does not support virtualization so it tries to render all items at once. Not sure if that's what causing this issue but if wrap panel gets reintroduced we need to check perfo on large folders.

@yaira2
Copy link
Member

yaira2 commented Jan 13, 2023

I temporarily reverted the change because of the issue, the code is still there but commented out. I think we'll have to find a different way to wrap the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants