-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix katex shortcode and EC, leader election and Poisson sortition update #1066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the Poisson Sortition section and have no technical objections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments as I read this to understand the different proofs, tickets, consensus algos, randomness, VRFs, etc.
@@ -401,6 +401,6 @@ A single consensus fault results into: | |||
|
|||
### Detection and Reporting | |||
|
|||
A node that detects and report a consensus fault is called "slasher", any user in Filecoin can be a slasher. They can report consensus faults by calling the `ReportConsensusFault` on the `StorageMinerActor` of the faulty miner. The slasher is rewarded with a portion of the offending miner's [Pledge Collateral](miner_collaterals) for notifying the network of the consensu fault. | |||
A node that detects and reports a consensus fault is called "slasher". Any user in Filecoin can be a slasher. They can report consensus faults by calling the `ReportConsensusFault` on the `StorageMinerActor` of the faulty miner. The slasher is rewarded with a portion of the _offending miner's block reward_ (as opposed to the miner's initial pledge) for notifying the network of the consensus fault. The reward should not be taken from the offending miner's initial pledge as the miner could have spent their initial pledge in earlier penalties and therefore cause more harm to the network. Recall that a miner who causes a consensus fault on purpose is the first to know about it (i.e., the network can only discover later) and can report it first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the code, I suggest to write this
"A node that detects and reports a consensus fault is called "slasher". Any user in Filecoin can be a slasher. They can report consensus faults by calling the ReportConsensusFault
on the StorageMinerActor
of the faulty miner. The slasher is rewarded with a portion of the penalty paid by the offending miner ConsensusFaultPenalty
for notifying the network of the consensus fault. Note that some slasher might not get the full reward because of a low balance for the offending miners, however for honest miner is still rational to notify the network about consensus faults."
And remove the rest:
The reward should not be taken from the offending miner's initial pledge as the miner could have spent their initial pledge in earlier penalties and therefore cause more harm to the network. Recall that a miner who causes a consensus fault on purpose is the first to know about it (i.e., the network can only discover later) and can report it first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irenegia thanks! I've reworded a bit - can you please double-check the phrasing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine with me!
This PR is applying all the latest changes in the Expected Consensus, Leader Election and the rationale behind Poisson Sortition of WinCount. It builds on top of the changes merged from #967