Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

Remove repeated calls to reward/power actors to get data inside OnDeferredCronEvent #1486

Closed
laudiacay opened this issue Sep 21, 2021 · 1 comment
Closed

Remove repeated calls to reward/power actors to get data inside OnDeferredCronEvent #1486

laudiacay opened this issue Sep 21, 2021 · 1 comment

Comments

@laudiacay
Copy link
Contributor

They're already being computed in OnEpochTick, should just pass them in instead.

Original discussion here: #1480 (comment)_
@laudiacay laudiacay mentioned this issue Sep 21, 2021
Merged
@laudiacay
Copy link
Contributor Author

there is apparently a commit that does exactly this in some repo that @ZenGround0 linked me in slack DMs (this is just a reminder for future @laudiacay)

ZenGround0 pushed a commit that referenced this issue Oct 13, 2021
@laudiacay @ZenGround0
Fix #1486 (#1489)
b1b8451 
* two more failing tests but otherwise working
* code review? code reviewed.
* tests passin\'
* https://www.youtube.com/watch?v=W1i4mTyidOc check pass
* found the source of the cbor errors.... forgot about gen.go.
* fixes for code review
* bump determinism hash
Co-authored-by: ZenGround0 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@laudiacay