Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nv16] actor bundle integration #8509

Merged
merged 8 commits into from
Apr 19, 2022
Merged

[nv16] actor bundle integration #8509

merged 8 commits into from
Apr 19, 2022

Conversation

vyzo
Copy link
Contributor

@vyzo vyzo commented Apr 19, 2022

This ingests the bundles produced at release and selects the appropriate bundle based on build tags.

TBD:

  • update ffi
  • select bundle by build tags
  • DI ingest test bundle by file when instantiating itests

@vyzo vyzo force-pushed the feat/actor-bundles branch 3 times, most recently from 1f43a65 to 9d904bb Compare April 19, 2022 15:27
@vyzo vyzo marked this pull request as ready for review April 19, 2022 15:44
@vyzo vyzo requested a review from a team as a code owner April 19, 2022 15:44
@vyzo vyzo requested a review from magik6k April 19, 2022 15:45
Copy link
Member

@raulk raulk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like the per-network build_* files, as we are trying to make the network parameterization less static in other efforts. But this works for now.

@raulk raulk merged commit 3e5037d into feat/nv16 Apr 19, 2022
@raulk raulk deleted the feat/actor-bundles branch April 19, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants