Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testkit: give up on waiting for the RPC server to shutdown after 1s #8450

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Apr 7, 2022

Some itests fail to complete because the testkit RPC server blocks waiting for all incoming connections to be closed.
This PR changes the shutdown code to wait up to 1s and then give up on shutting down the server.

@dirkmc dirkmc requested a review from a team as a code owner April 7, 2022 10:21
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #8450 (c34ade9) into master (f652dd3) will decrease coverage by 0.00%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8450      +/-   ##
==========================================
- Coverage   40.67%   40.66%   -0.01%     
==========================================
  Files         686      686              
  Lines       75426    75439      +13     
==========================================
- Hits        30678    30677       -1     
- Misses      39450    39464      +14     
  Partials     5298     5298              
Impacted Files Coverage Δ
itests/kit/rpc.go 95.00% <78.57%> (-5.00%) ⬇️
markets/loggers/loggers.go 89.28% <0.00%> (-10.72%) ⬇️
extern/sector-storage/worker_tracked.go 79.82% <0.00%> (-7.02%) ⬇️
chain/stmgr/tracers.go 84.21% <0.00%> (-5.27%) ⬇️
extern/storage-sealing/currentdealinfo.go 72.97% <0.00%> (-3.61%) ⬇️
chain/sub/incoming.go 45.25% <0.00%> (-2.45%) ⬇️
blockstore/autobatch.go 56.30% <0.00%> (-1.69%) ⬇️
chain/store/store.go 64.33% <0.00%> (-1.17%) ⬇️
chain/sync.go 70.52% <0.00%> (-0.35%) ⬇️
chain/messagepool/messagepool.go 63.65% <0.00%> (-0.25%) ⬇️
... and 7 more

itests/kit/rpc.go Outdated Show resolved Hide resolved
Co-authored-by: Anton Evangelatov <[email protected]>
@magik6k magik6k merged commit b26ac2b into master Apr 7, 2022
@magik6k magik6k deleted the fix/testkit-rpc-shutdown branch April 7, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants