-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ux: wallet: update delete usage #8442
ux: wallet: update delete usage #8442
Conversation
Renaming the function to soft-delete to better reflect what it does - and specify that a hard deletion is needed for permanent removal.
Change from `delete` to `soft-delete` in the TestWalleteDelete test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot just rename an existing command, it will break existing scripts.
We could proceed with the rename but we should add an alias to delete
and maybe a deprecation notice. @jennijuju what do you think?
Yes, thanks for the callout! I would say maybe we can just keep it simple - update the usage and keep the name?> @Kubuxu any preference? |
no really, can really go either way for me |
Updating the usage is sufficient imo. |
Revert `soft-delete` cmd back to `delete`. Keeps the updated usage
Codecov Report
@@ Coverage Diff @@
## master #8442 +/- ##
==========================================
- Coverage 40.26% 40.19% -0.08%
==========================================
Files 683 683
Lines 74480 74480
==========================================
- Hits 29989 29936 -53
- Misses 39263 39303 +40
- Partials 5228 5241 +13
|
Is there any instruction we can give folks on HOW to hard delete the file? Seems like an important next step we should make accessible but very clear to avoid mistakes! Is there a “hard-delete” command we could add? |
Renaming the cmd to soft-delete to better reflect what it does - and specify that a hard deletion is needed for permanent removal.
Should address #6926 to a degree, becuase it tells the user that extra steps are needed at least.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea
: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps