Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: piece provider: Don't log CIDs as binary #8287

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

magik6k
Copy link
Contributor

@magik6k magik6k commented Mar 10, 2022

Related Issues

Fixes #8107

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@magik6k magik6k requested a review from a team as a code owner March 10, 2022 13:28
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #8287 (91ccb7f) into master (326a9b6) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8287      +/-   ##
==========================================
- Coverage   40.53%   40.50%   -0.04%     
==========================================
  Files         675      675              
  Lines       73527    73527              
==========================================
- Hits        29805    29780      -25     
- Misses      38500    38524      +24     
- Partials     5222     5223       +1     
Impacted Files Coverage Δ
extern/sector-storage/piece_provider.go 55.31% <100.00%> (ø)
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
chain/events/observer.go 71.64% <0.00%> (-6.72%) ⬇️
storage/wdpost_sched.go 77.45% <0.00%> (-3.93%) ⬇️
miner/miner.go 55.08% <0.00%> (-2.96%) ⬇️
chain/events/events_height.go 68.90% <0.00%> (-2.53%) ⬇️
extern/sector-storage/sched.go 84.77% <0.00%> (-0.83%) ⬇️
chain/store/store.go 63.00% <0.00%> (-0.67%) ⬇️
extern/sector-storage/sched_worker.go 78.48% <0.00%> (-0.59%) ⬇️
itests/kit/blockminer.go 69.61% <0.00%> (-0.56%) ⬇️
... and 7 more

@magik6k magik6k merged commit 55189fb into master Mar 10, 2022
@magik6k magik6k deleted the fix/dont-log-binary-cids branch March 10, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dagstore Migration Causes Invalid Characters In Log
2 participants