Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:sealing:Log instead of error normal shutdown of state machine #8232

Merged
merged 1 commit into from
Mar 3, 2022

Conversation

ZenGround0
Copy link
Contributor

@ZenGround0 ZenGround0 commented Mar 2, 2022

Related Issues

Proposed Changes

normal shutdown of state machine error will be logged but it won't kill the ability to update sector state from lotus-miner cli

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • All commits have a clear commit message.
  • The PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, test
    • area: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps
  • This PR has tests for new functionality or change in behaviour
  • If new user-facing features are introduced, clear usage guidelines and / or documentation updates should be included in https://lotus.filecoin.io or Discussion Tutorials.
  • CI is green

@ZenGround0 ZenGround0 requested a review from a team as a code owner March 2, 2022 20:05
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #8232 (b81d189) into master (14b7674) will increase coverage by 0.09%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8232      +/-   ##
==========================================
+ Coverage   40.47%   40.57%   +0.09%     
==========================================
  Files         666      666              
  Lines       72925    72932       +7     
==========================================
+ Hits        29516    29591      +75     
+ Misses      38201    38131      -70     
- Partials     5208     5210       +2     
Impacted Files Coverage Δ
extern/storage-sealing/fsm.go 55.40% <18.75%> (-0.65%) ⬇️
chain/actors/builtin/miner/diff.go 48.52% <0.00%> (-10.30%) ⬇️
miner/miner.go 52.13% <0.00%> (-4.60%) ⬇️
chain/stmgr/call.go 71.51% <0.00%> (-3.64%) ⬇️
chain/types/tipset_key.go 85.96% <0.00%> (-3.51%) ⬇️
blockstore/buffered.go 34.44% <0.00%> (-2.23%) ⬇️
chain/gen/gen.go 68.19% <0.00%> (-1.23%) ⬇️
storage/wdpost_changehandler.go 97.64% <0.00%> (-0.95%) ⬇️
chain/sync_manager.go 73.91% <0.00%> (-0.63%) ⬇️
chain/messagepool/messagepool.go 63.15% <0.00%> (-0.62%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b7674...b81d189. Read the comment docs.

extern/storage-sealing/fsm.go Show resolved Hide resolved
@magik6k magik6k merged commit 6b06c1b into master Mar 3, 2022
@magik6k magik6k deleted the fix/not-so-normal-shutdown-of-state-machine branch March 3, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants