Feat: cli: Remove verified data cap #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8175 +/- ##
==========================================
- Coverage 39.91% 39.82% -0.10%
==========================================
Files 666 666
Lines 72554 72733 +179
==========================================
+ Hits 28963 28965 +2
- Misses 38553 38717 +164
- Partials 5038 5051 +13
Continue to review full report at Codecov.
|
arajasek
reviewed
Feb 23, 2022
cli/filplus.go
Outdated
|
|
||
| var filplusSignRemoveDataCapProposal = &cli.Command{ | ||
| Name: "sign-remove-data-cap-proposal", | ||
| Usage: "TODO", |
cli/filplus.go
Outdated
| } | ||
| } | ||
|
|
||
| // TODO: This should be abstracted over actor versions |
cli/filplus.go
Outdated
| }, | ||
| Action: func(cctx *cli.Context) error { | ||
| if cctx.Args().Len() != 3 { | ||
| return fmt.Errorf("must specify three arguments: verifier address, client address, and allowance to remove") |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("must specify three arguments: verifier address, client address, and allowance to remove") | |
| return fmt.Errorf("must specify three arguments: notary address, client address, and allowance to remove") |
Co-authored-by: Aayush Rajasekaran <[email protected]>
Co-authored-by: Aayush Rajasekaran <[email protected]>
|
Needs make gen |
arajasek
approved these changes
Feb 24, 2022
| return false, 0, xerrors.Errorf("loading verifreg: %w", err) | ||
| } | ||
| if vh == nil { | ||
| return false, 0, xerrors.Errorf("remove data cap proposal hamt not found. you are probably using an incompatible version of actors") |
There was a problem hiding this comment.
Suggested change
| return false, 0, xerrors.Errorf("remove data cap proposal hamt not found. you are probably using an incompatible version of actors") | |
| return false, 0, xerrors.Errorf("remove data cap proposal hamt not found (only exists from v7 and after)") |
Co-authored-by: Aayush Rajasekaran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes Issue #7863
Proposed Changes
Added the following cli commands:
lotus filplus sign-remove-data-cap-proposal
lotus-shed verifreg remove-verified-client-data-cap
Additional Info
Tested on devnet. Works as expected.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps