add a state-tree diff command to lotus shed #8081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
force-pushed
the
feat/shed-state-diff
branch
from
aaed2a9
to
0bd79d8
Compare
Stebalien
force-pushed
the
feat/shed-state-diff
branch
from
0bd79d8
to
6cafec1
Compare
This makes it easier to debug state mismatches by providing a nice way to figure out which actors differ between two state-trees and how (balance, nonce, state, etc.). It doesn't provide a way to actually _diff_ those state-trees, but one can use `lotus chain get` to figure that out (although it would be _nice_ to provide something a bit smarter).
Stebalien
force-pushed
the
feat/shed-state-diff
branch
from
6cafec1
to
e89f7d9
Compare
Codecov Report
@@ Coverage Diff @@
## master #8081 +/- ##
==========================================
- Coverage 39.13% 39.06% -0.07%
==========================================
Files 662 663 +1
Lines 72160 72216 +56
==========================================
- Hits 28242 28214 -28
- Misses 39008 39090 +82
- Partials 4910 4912 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to debug state mismatches by providing a nice way to figure out which actors differ between two state-trees and how (balance, nonce, state, etc.).
It doesn't provide a way to actually diff those state-trees, but one can use
lotus chain getto figure that out (although it would be nice to provide something a bit smarter).Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, depsThis PR has tests for new functionality or change in behaviour(shed yolo)