Verify Voucher locks in VoucherValidUnlocked #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
approved these changes
Mar 24, 2021
| @@ -344,6 +344,7 @@ func (pm *Manager) trackInboundChannel(ctx context.Context, ch address.Address) | |||
| return pm.store.TrackChannel(stateCi) | |||
| } | |||
|
|
|||
| // TODO: secret vs proof doesn't make sense, there is only one, not two | |||
There was a problem hiding this comment.
I believe we had both at some point in the past
There was a problem hiding this comment.
We did. But it wasn't usable so we removed it from actors.
|
Lint is not happy due to there being extra function in tests. In future, it might be used. |
|
@jennijuju can you take a look at getting this merged. I thought it was merged ages ago. |
added 3 commits
July 27, 2021 09:10
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Signed-off-by: Jakub Sztandera <[email protected]>
Stebalien
requested changes
Jul 27, 2021
| @@ -344,6 +344,7 @@ func (pm *Manager) trackInboundChannel(ctx context.Context, ch address.Address) | |||
| return pm.store.TrackChannel(stateCi) | |||
| } | |||
|
|
|||
| // TODO: secret vs proof doesn't make sense, there is only one, not two | |||
There was a problem hiding this comment.
We did. But it wasn't usable so we removed it from actors.
|
@Stebalien are you still requesting changes here or did we clear it up? |
Stebalien
approved these changes
Jul 29, 2021
|
@Kubuxu please followup with a patch to test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.