-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update GST, Filecoin-FFI and Actors to final versions NV24 #12658
Conversation
chore: bump GST to v0.15.0
chore: bump filecoin-ffi to v1.30.0
chore: update builtin-actors to v15.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
PR title now matches the required format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so the cbor-gen bump propagated here, so it's worth looking at what that gives us: whyrusleeping/cbor-gen@v0.1.2...v0.2.0
- The big thing in that bump was the optional sorting of struct fields, which we don't want and shouldn't touch. I think this was probably a bluesky thing and it shouldn't impact our code paths.
- The thing that does touch us is @Stebalien 's rejection of negative bigints, which should be fine, mainly because we have our own bigint encoding that does these as bytes, so we shouldn't go anywhere near that code (I'm not sure that fix has anything to do with filecoin? maybe it does for f3?).
- Our bigint byte format: https://github.com/filecoin-project/go-state-types/blob/3524467d26605ec24d4704c7d5d3376598a3d814/big/int.go#L221
- Used by a custom
MarshalCBOR
: https://github.com/filecoin-project/go-state-types/blob/3524467d26605ec24d4704c7d5d3376598a3d814/big/int.go#L284-L297
- There were a few perf improvements in there.
Overall this should be fine, maybe we should have pushed this earlier through an RC but the risk seems very low to me.
…2658) * chore: bump GST to v0.15.0 chore: bump GST to v0.15.0 * chore: bump filecoin-ffi to v1.30.0 chore: bump filecoin-ffi to v1.30.0 * chore: update builtin-actors to v15.0.0 chore: update builtin-actors to v15.0.0
…2658) * chore: bump GST to v0.15.0 chore: bump GST to v0.15.0 * chore: bump filecoin-ffi to v1.30.0 chore: bump filecoin-ffi to v1.30.0 * chore: update builtin-actors to v15.0.0 chore: update builtin-actors to v15.0.0
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that: