Revert "feat: fix GetBlock for null rounds by returning nil (#12529)" #12641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please update the PR title to match https://github.com/filecoin-project/lotus/blob/master/CONTRIBUTING.md#pr-title-conventions
8 tasks
This reverts commit c674554.
rvagg
force-pushed
the
rvagg/revert-getblocknull
branch
from
c25dc5e
to
2893441
Compare
|
I've left |
|
I'm also ignoring the request to fix the title and I'm going to PR the bot to accept |
aarshkshah1992
approved these changes
Oct 28, 2024
rvagg
dismissed
github-actions[bot]’s stale review
valid commit message for revert
This was referenced Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c674554.
Discussion in #12633 about the subtleties of dealing with this problem - returning nil or an error. This could be an unfixable wac-a-mole, but the fact that we had a complaint pretty quickly on an RC for just this API shows that we need to tread more cautiously.