feat(f3): remove lease-check interval constants #12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
added
the
skip/changelog
Stebalien
commented
Oct 10, 2024
1. Instead of hard-coding the renewal to be within 2 instances of the end of the lease, specify the renewal to be within 1/2th of the end of the lease, rounded up (towards the end of the lease). 2. Instead of hard-coding the lease check interval to be 10s (problematic for tests where the block time is 100ms), set it to be the minimum amount of time we expect to have to wait for the remaining instances to complete.
Stebalien
force-pushed
the
steb/lease-check-interval
branch
from
8a25f6b
to
509136b
Compare
|
Note: it would be nice to tune the backoff in the same way, but that's tricker. |
masih
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
I expect this may help with some of the flaky tests as those may have been timing out because we weren't renewing the lease fast enough.
#12519
Proposed Changes
instances to complete.
I've configured a hard-coded minimum of renewing the lease once every 100ms in case a manifest doesn't have a configured catch-up alignment interval, but I don't expect us to hit that in practice.
Checklist
Before you mark the PR ready for review, please make sure that: