Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] chore: config: yet more lp2p removal from miner #12252

Conversation

ribasushi
Copy link
Collaborator

Related Issues

#12100

Proposed Changes

There is no lp2p/pubsub in lotus-miner these days. Amazing how more and more code gets found...

@ribasushi ribasushi force-pushed the chore/more_markets_lp2p_removal branch from e560d04 to 2b81d94 Compare July 17, 2024 17:38
@ribasushi ribasushi marked this pull request as ready for review July 17, 2024 20:09
@ribasushi
Copy link
Collaborator Author

cc @rvagg

@ribasushi ribasushi force-pushed the chore/more_markets_lp2p_removal branch from 2b81d94 to 17297df Compare July 18, 2024 07:56
@ribasushi
Copy link
Collaborator Author

@aarshkshah1992 still good for review - force pushed to resolve conflicts with #12257

@ribasushi
Copy link
Collaborator Author

@rjan90 this one is a potential backport: it removes config/documentation that no longer does anything (part of the long-slog markets removal)

@rjan90
Copy link
Contributor

rjan90 commented Jul 18, 2024

@rjan90 this one is a potential backport: it removes config/documentation that no longer does anything (part of the long-slog markets removal)

I put a backport-label on it now. And also added a comment/question on one part which seemed to touch a bit more then just markets (Edit: cleared up, was just too quick glancing through the diff)

Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aarshkshah1992
Copy link
Contributor

@ribasushi Merging.

@aarshkshah1992 aarshkshah1992 merged commit 11dd4c9 into filecoin-project:master Jul 19, 2024
78 checks passed
@ribasushi ribasushi deleted the chore/more_markets_lp2p_removal branch July 19, 2024 08:34
@rjan90 rjan90 mentioned this pull request Jul 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants