Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lotus-provider: Fix log output format in wdPostTaskCmd #11504

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

rjan90
Copy link
Contributor

@rjan90 rjan90 commented Dec 8, 2023

Proposed Changes

Fixes a minor issue in the logging output of the wdPostTaskCmd action in the proving.go file. Previously, the log output for the result was not formatted correctly, leading to extraneous output in the logs.

Additional Info

Before you would get Result:%!(EXTRA string=

lotus-provider --db-host=localhost test window-post task
repopath ~/.lotusprovider
Inserted task 1701. Waiting for success 2023-12-07T11:30:24.502+0100	INFO	mainlotus-provider/proving.go:120	Result:%!(EXTRA string={
  "deadline": 0,
  "partition": 0,
  "proof_params": "hQCBggBAgYIKWMCnQ1eJeQ3JcqgJkwuRW/9zOOvQD3T0gFiGwuZoGgWC0Zp+/b40HKVC932VjaybzVmr8rAVDOZSLLqWTOl1CdpSCp4LGSiv5dMBo8G3GsMCqVM8LsM7KSjNMZiqefOgtBQQPJ3U5DYdpHLeZPsugeicQuayvHE6oJpwBzY7z4f58TYJIS3f5AQl77tsYilbtvmi7tGbUTUSbPskY8kgi8u6XI9+/IjsV6U/B9FcDhFiegcuH+MH1/Rde9K4GunCF/MAQA==",
  "proving_period_start": 1927,
  "sp_id": 1000,
  "submit_at_epoch": 1927,
  "submit_by_epoch": 1987
})

After

lotus-provider --db-host=localhost test window-post task
repopath ~/.lotusprovider
Inserted task 3201. Waiting for success ..2023-12-07T11:45:12.398+0100	INFO	main	lotus-provider/proving.go:120	Result: {
  "deadline": 0,
  "partition": 0,
  "proof_params": "hQCBggBAgYIKWMCHeORdGlSN4ERtOg/VRPdAB9LQp9+LuBIegdO0EFnFuAAgQwsnIlJeKJcXnoaKeYCnAmmKM4CMHLf6Jp9+I2R84CK/EhW7hR/3yo7QtHTRS/IjPLeMa/V8Pkf4YPAEUxoXoKyoEY0aFFvOb2IyWn5M8GTLNfxrMhooPAN/VBRKcLAtyyM4bYf3rC8y6un5yB2Kg1Xm/Pl71RavBTXB69avbVdHCmRe/o4iM+Ww8ZacsyYrWRfW3+2JnLwfJriDGAMAQA==",
  "proving_period_start": 2149,
  "sp_id": 1000,
  "submit_at_epoch": 2149,
  "submit_by_epoch": 2209
}

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

Fix log output format in wdPostTaskCmd
@rjan90 rjan90 requested a review from a team as a code owner December 8, 2023 08:26
@rjan90 rjan90 requested review from snissn and magik6k December 8, 2023 08:26
@magik6k magik6k merged commit 68c1e56 into master Dec 11, 2023
89 checks passed
@magik6k magik6k deleted the lp-wdposttaskcmd-format branch December 11, 2023 12:30
rjan90 pushed a commit that referenced this pull request Dec 11, 2023
fix: lotus-provider: Fix log output format in wdPostTaskCmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants