Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sealing: Run unsealing in the background for better ux #11177

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

shrenujbansal
Copy link
Contributor

Related Issues

#11133

Proposed Changes

Run the unsealing task in a background context so the unseal cmd doesn't hang while the process runs for multiple hours

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@shrenujbansal shrenujbansal requested a review from a team as a code owner August 16, 2023 21:22
@snadrus
Copy link
Collaborator

snadrus commented Aug 16, 2023

Great, now how can we determine if it's still running or what the result is?

@rjan90
Copy link
Contributor

rjan90 commented Aug 17, 2023

Great, now how can we determine if it's still running or what the result is?

The lotus-miner sealing jobs cmd lists out the current running sealing jobs, so you will see the UNS-job there while it is running.

@rjan90 rjan90 linked an issue Aug 21, 2023 that may be closed by this pull request
11 tasks
@snadrus snadrus merged commit cb7231c into master Aug 21, 2023
@snadrus snadrus deleted the sbansal/unseal-background branch August 21, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lotus-miner sectors unseal <sector> hangs.
3 participants