Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chain get no longer works #7701

Closed
8 of 18 tasks
Kubuxu opened this issue Nov 27, 2021 · 7 comments · Fixed by #7751
Closed
8 of 18 tasks

chain get no longer works #7701

Kubuxu opened this issue Nov 27, 2021 · 7 comments · Fixed by #7751
Labels
kind/bug Kind: Bug P1 P1: Must be resolved

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 27, 2021

Checklist

  • This is not a security-related bug/issue. If it is, please follow please follow the security policy.
  • This is not a question or a support request. If you have any lotus related questions, please ask in the lotus forum.
  • This is not a new feature request. If it is, please file a feature request instead.
  • This is not an enhancement request. If it is, please file a improvement suggestion instead.
  • I have searched on the issue tracker and the lotus forum, and there is no existing related issue or discussion.
  • I am running the Latest release, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.
  • I did not make any code changes to lotus.

Lotus component

  • lotus daemon - chain sync
  • lotus miner - mining and block production
  • lotus miner/worker - sealing
  • lotus miner - proving(WindowPoSt)
  • lotus miner/market - storage deal
  • lotus miner/market - retrieval deal
  • lotus miner/market - data transfer
  • lotus client
  • lotus JSON-RPC API
  • lotus message management (mpool)
  • Other

Lotus Version

Daemon:  1.13.2-dev+mainnet+git.e196a81e9.dirty+api1.4.0
Local: lotus version 1.13.2-dev+mainnet+git.e196a81e9.dirty

Describe the Bug

Calling lotus chain get returns "empty" output.

./lotus chain get  bafy2bzacebcd4btqq6zgelu6dmnqd5qtoj2kttdtwkqsespkxfmu35fswn2i4
{
        "Block": {},
        "Node": {}
}

Logging Information

<no related log output>

Repo Steps

Call lotus chain get bafy2bzacebcd4btqq6zgelu6dmnqd5qtoj2kttdtwkqsespkxfmu35fswn2i4 which is one of the states of the market actor. but calling lotus chain get /pstate also reproduces it.

@jennijuju
Copy link
Member

the bug is introduced by v1.13.1 and should be in ChainGetNode.

@jennijuju jennijuju added need/analysis Hint: Needs Analysis P1 P1: Must be resolved and removed need/triage labels Dec 8, 2021
@jennijuju
Copy link
Member

jennijuju commented Dec 8, 2021

go get: downgraded github.com/ipfs/go-merkledag v0.4.1 => v0.3.2 fix it. the dep upgrade was introduced by 8b01725 seems like the main difference is 0.3.2 gives us the node_type as cbor map[cid:xxx node_type:cbor] where 0.4.1 gives the block map[block:]

@ribasushi
Copy link
Collaborator

@willscott @warpfork ☝️ does this ring a bell?
cbor map[cid:xxx node_type:cbor] with v0.3.2
vs
block map[block:] with v0.4.1

@willscott
Copy link
Contributor

cc on @hannahhoward for connecting the dots on the ipld-prime update that happened in that bump of go-merkledag.

@mur-me
Copy link

mur-me commented Dec 9, 2021

Hey @jennijuju , will this issue be included in the upcoming 1.13.2 release?

@jennijuju
Copy link
Member

jennijuju commented Dec 9, 2021

pulling in ipfs/go-ipld-legacy#7 should fix it.

@jennijuju
Copy link
Member

Hey @jennijuju , will this issue be included in the upcoming 1.13.2 release?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Kind: Bug P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants