Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If miner replaces publish deal message, it does not update that in its deal state #7009

Closed
whyrusleeping opened this issue Aug 9, 2021 · 2 comments · Fixed by #7450
Closed
Labels
area/markets/storage P1 P1: Must be resolved
Milestone

Comments

@whyrusleeping
Copy link
Member

If a miner publishes a deal, but then does an mpool replace on that message before it lands (to increase the gas limit, or something) the cid recorded in their markets state store for the deal does not get updated. This leads to clients never really finding out that their data has made it into a deal, and leads to a lot of faults in estuary (estuary will mark the deal as failed on its end because it has no way of knowing that it actually landed on chain).

We can work around this by just waiting for the miner to update the deal ID in their deal status response, but this requires a good deal of extra logic to validate that everything is correct.

@whyrusleeping
Copy link
Member Author

Still getting this:

2021-09-29T09:30:56.147Z        ERROR   estuary estuary/replication.go:379      failed to ensure replication of content 9123628: failed to check deal id: could not find published deal on chain: checking for message execution during lookback: found message with equal nonce as the one we are looking for (F:bafy2bzaced5e2s5awfhhgxgeisr66r47oruoowal34sydrp32dtduylk4hxiw n 18732, TS: bafy2bzaced5e2s5awfhhgxgeisr66r47oruoowal34sydrp32dtduylk4hxiw n18732)

@jennijuju jennijuju added P1 P1: Must be resolved area/markets/storage labels Oct 4, 2021
@jennijuju jennijuju added this to the v1.13.1 milestone Oct 4, 2021
@jennijuju
Copy link
Member

Might be worth looking into how sealing pipeline/fsm is handling getting replaced message and follow a similar logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/markets/storage P1 P1: Must be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants