Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-examine HyperDrive params that depend on the size of aggregations #6517

Closed
arajasek opened this issue Jun 17, 2021 · 3 comments
Closed

Re-examine HyperDrive params that depend on the size of aggregations #6517

arajasek opened this issue Jun 17, 2021 · 3 comments
Assignees
Labels
P1 P1: Must be resolved

Comments

@arajasek
Copy link
Contributor

#6515 revealed an issue (since fixed) in proof de/serialization that was leading to things being bigger than expected.

We need to reassess values

  • We need to rerun gas calculations to see if there's a significant change in validation time resulting from the fix (a slowdown is expected, but unclear how large)
  • If the change is small, we proceed with our current values
  • If the change is large, we recompute gas values (takes ~2 days)
  • If we recompute gas values, we also need to revisit bounds on aggregation batch sizes in actors

If anyone knows of any other values similarly affected, please flag below

@arajasek arajasek added this to the Network Hyperdrive milestone Jun 17, 2021
@arajasek arajasek added the P1 P1: Must be resolved label Jun 17, 2021
@jennijuju
Copy link
Member

jennijuju commented Jun 17, 2021

small is defined as within 20% by @Kubuxu

@jennijuju
Copy link
Member

jennijuju commented Jun 17, 2021

Also the balancer/gas discount value?

@Kubuxu
Copy link
Contributor

Kubuxu commented Jun 18, 2021

The result is 6% slower. Closing.

@Kubuxu Kubuxu closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 P1: Must be resolved
Projects
None yet
Development

No branches or pull requests

3 participants